Skip to content

Add new command to collect data on mainline #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Goggags123 wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Add new command to collect data on mainline #126

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2b2974e
Add second command in yargs
Goggags123 Nov 9, 2021
66f8f7d
Modify config builder to have command as a parameter
Goggags123 Nov 9, 2021
41494f4
Modify YML handler to handle another command
Goggags123 Nov 9, 2021
cc422b0
Fix YML parser
Goggags123 Nov 9, 2021
26c6c04
Add new config file
Goggags123 Nov 9, 2021
d437404
Fix unit test
Goggags123 Nov 9, 2021
063d90c
Separate type
Goggags123 Nov 10, 2021
7e236d8
Change config name and remove unnecessary config
Goggags123 Nov 11, 2021
fd9a16e
Fix unit test
Goggags123 Nov 11, 2021
f1bdc72
Prepare required data for sending through API
Goggags123 Nov 11, 2021
f822d63
Add another config property 'branch'
Goggags123 Nov 14, 2021
aab08fa
Add branch to required arguments
Goggags123 Nov 14, 2021
6b4b0a1
Add groupby functionality
Goggags123 Nov 14, 2021
c872a59
Add functionality to send data via api
Goggags123 Nov 29, 2021
d964a0f
Fix error
Goggags123 Nov 29, 2021
253d1f5
Merge branch 'main' into add-collecting-data-on-mainline
Goggags123 Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix unit test
  • Loading branch information
@Goggags123
Goggags123 committed Nov 9, 2021
commit d437404b178e5de214ad7413fe74e277ce17d646
88 changes: 80 additions & 8 deletions src/Config/Config.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Config } from './Config';

const MOCK_ARGS = [
const PR_MOCK_ARGS = [
'/usr/local/Cellar/node/15.13.0/bin/node',
'/Users/codecoach/src/app.ts',
'--url=https://github.com/codeleague/codecoach.git',
Expand All @@ -11,13 +11,25 @@ const MOCK_ARGS = [
'-o=./tmp/out.json',
];

const MOCK_ARGS_W_CONFIG_YAML = [
const PR_MOCK_ARGS_W_COMMAND = [
'/usr/local/Cellar/node/15.13.0/bin/node',
'/Users/codecoach/src/app.ts',
'comment',
'--url=https://github.com/codeleague/codecoach.git',
'--removeOldComment',
'--token=placeyourtokenhere',
'--pr=15',
'-f=dotnetbuild;./sample/dotnetbuild/build.content;/repo/src',
'-o=./tmp/out.json',
];

const PR_MOCK_ARGS_W_CONFIG_YAML = [
'/usr/local/Cellar/node/15.13.0/bin/node',
'/Users/codecoach/src/app.ts',
'--config=sample/config/config.yaml',
];

export const EXPECTED_MOCK_ARGS = [
export const PR_EXPECTED_MOCK_ARGS = [
'/usr/local/Cellar/node/15.13.0/bin/node',
'/Users/codecoach/src/app.ts',
'https://github.com/codeleague/codecoach.git',
Expand All @@ -28,23 +40,83 @@ export const EXPECTED_MOCK_ARGS = [
'./tmp/out.json',
];

describe('Config Test', () => {
const DATA_MOCK_ARGS = [
'/usr/local/Cellar/node/15.13.0/bin/node',
'/Users/codecoach/src/app.ts',
'collect',
'--url=https://github.com/codeleague/codecoach.git',
'-r=3',
'-c=latestcommitsha',
'--token=placeyourtokenhere',
'-f=dotnetbuild;./sample/dotnetbuild/build.content;/repo/src',
'-o=./tmp/out.json',
];

const DATA_MOCK_ARGS_W_CONFIG_YAML = [
'/usr/local/Cellar/node/15.13.0/bin/node',
'/Users/codecoach/src/app.ts',
'collect',
'--config=sample/config/dataConfig.yaml',
];

export const DATA_EXPECTED_MOCK_ARGS = [
'/usr/local/Cellar/node/15.13.0/bin/node',
'/Users/codecoach/src/app.ts',
'https://github.com/codeleague/codecoach.git',
3,
'latestcommitsha',
'placeyourtokenhere',
'dotnetbuild;./sample/dotnetbuild/build.content;/repo/src',
'./tmp/out.json',
];

describe('PR config Test', () => {
let config: typeof Config;

beforeEach(() => {
jest.resetModules();
});

it('Should able to parse this args and run without throwing error', async () => {
process.argv = PR_MOCK_ARGS;
config = (await import('./Config')).Config;
let fullfillConfig = await config;
expect(fullfillConfig.provider.repoUrl).toBe(PR_EXPECTED_MOCK_ARGS[2]);
expect(fullfillConfig.provider.removeOldComment).toBe(PR_EXPECTED_MOCK_ARGS[3]);

process.argv = PR_MOCK_ARGS_W_COMMAND;
config = (await import('./Config')).Config;
fullfillConfig = await config;
expect(fullfillConfig.provider.repoUrl).toBe(PR_EXPECTED_MOCK_ARGS[2]);
expect(fullfillConfig.provider.removeOldComment).toBe(PR_EXPECTED_MOCK_ARGS[3]);
});

it('Should able to use a config file without passing other args', async () => {
process.argv = PR_MOCK_ARGS_W_CONFIG_YAML;
config = (await import('./Config')).Config;
const fullfillConfig = await config;
expect(fullfillConfig.app.buildLogFiles[0].type).toBe('tslint');
});
});

describe('Data config Test', () => {
let config: typeof Config;

beforeEach(() => {
jest.resetModules();
});

it('Should able to parse this args and run without throwing error', async () => {
process.argv = MOCK_ARGS;
process.argv = DATA_MOCK_ARGS;
config = (await import('./Config')).Config;
const fullfillConfig = await config;
expect(fullfillConfig.provider.repoUrl).toBe(EXPECTED_MOCK_ARGS[2]);
expect(fullfillConfig.provider.removeOldComment).toBe(EXPECTED_MOCK_ARGS[3]);
expect(fullfillConfig.provider.repoUrl).toBe(DATA_EXPECTED_MOCK_ARGS[2]);
expect(fullfillConfig.provider.runId).toBe(DATA_EXPECTED_MOCK_ARGS[3]);
expect(fullfillConfig.provider.latestCommit).toBe(DATA_EXPECTED_MOCK_ARGS[4]);
});

it('Should able to use a config file without passing other args', async () => {
process.argv = MOCK_ARGS_W_CONFIG_YAML;
process.argv = DATA_MOCK_ARGS_W_CONFIG_YAML;
config = (await import('./Config')).Config;
const fullfillConfig = await config;
expect(fullfillConfig.app.buildLogFiles[0].type).toBe('tslint');
Expand Down
14 changes: 12 additions & 2 deletions src/Config/YML.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,20 @@
import { COMMAND } from './constants/defaults';
import { YML } from './YML';

describe('YML Test', () => {
describe('PR YML Test', () => {
it('Should able to validate yaml file correctly', async () => {
const config = await YML.parse('sample/config/config.yaml');
const config = await YML.parse('sample/config/config.yaml', COMMAND.DEFAULT);
expect(config.output).toBe('./output.json');
expect(config.repo.pr).toBe(40);
expect(config.repo.removeOldComment).toBe(false);
});
});

describe('Data YML Test', () => {
it('Should able to validate yaml file correctly', async () => {
const config = await YML.parse('sample/config/dataConfig.yaml', COMMAND.COLLECT);
expect(config.output).toBe('./output.json');
expect(config.repo.runId).toBe(40);
expect(config.repo.latestCommit).toBe('123qwe123qwe123qwe123qwe123qwe123qwe123q');
});
});