Skip to content

feat: pass tokenless value as branch override #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joseph-sentry merged 11 commits into from
Aug 29, 2024
Merged

feat: pass tokenless value as branch override #1511

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c56aae1
feat: pass tokenless value as branch override
joseph-sentry Jul 15, 2024
30c7aa0
refactor: change getToken to return nullable output
joseph-sentry Jul 23, 2024
58f4498
fix: quick fix to use Promise resolve in getToken
joseph-sentry Jul 23, 2024
0c23ec5
test: add test for tokenless build commit exec
joseph-sentry Jul 26, 2024
f1d218a
test: fix tests
joseph-sentry Jul 29, 2024
66f3555
test: fix tests
joseph-sentry Jul 29, 2024
b3582f7
test: fix tests
joseph-sentry Jul 29, 2024
775cafb
test: fix tests
joseph-sentry Jul 29, 2024
d7991a5
fix: don't overwrite overrideBranch & add comments decribing getToken
joseph-sentry Aug 1, 2024
ad787cf
fix: address feedback
joseph-sentry Aug 28, 2024
bc200a8
fix: quick fix to use Promise resolve in getToken
joseph-sentry Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: quick fix to use Promise resolve in getToken
  • Loading branch information
@joseph-sentry
joseph-sentry committed Jul 23, 2024
commit 58f4498604786f0a073988bd913b86f0a2a58bf3
2 changes: 1 addition & 1 deletion dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32365,7 +32365,7 @@ const getToken = () => buildExec_awaiter(void 0, void 0, void 0, function* () {
}
try {
token = yield core.getIDToken(url);
return token;
return Promise.resolve(token);
}
catch (err) {
setFailure(`Codecov: Failed to get OIDC token with url: ${url}. ${err.message}`, true);
Expand Down
2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/buildExec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const getToken = async (): Promise<string | null> => {
}
try {
token = await core.getIDToken(url);
return token;
return Promise.resolve(token);
} catch (err) {
setFailure(
`Codecov: Failed to get OIDC token with url: ${url}. ${err.message}`,
Expand Down