fix: mcp-registry job checks out main for server.json - #20
Merged
Merged
Conversation
server.json lives on main (added after v0.2.1). The tag checkout can't find it. The registry publish only needs server.json with the version updated, not the Go source at that tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The mcp-registry job checked out the resolved tag, but
server.jsonwas added to main afterv0.2.1. The checkout couldn't find the file.Fix: check out main (default ref) instead of the tag. The registry publish only needs
server.jsonwith the version stamped from the tag, not the Go source at that commit.This also makes it resilient to tagging before updating
server.json.