Add quiz config field showQuestionsAfterSubmit - #75722
fisher-alice wants to merge 18 commits into
Conversation
This reverts commit 9a5b3f2.
| allowMultipleAttempts: true, | ||
| showCorrectness: true, | ||
| revealAnswerExplanation: true, | ||
| hideQuestionsAfterSubmit: false, |
There was a problem hiding this comment.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new builder test clicks an initially enabled toggle but incorrectly expects the submitted value to remain enabled.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds a quiz setting that hides per-question results after submission while retaining the score display.
Changes:
- Persists and exposes
hideQuestionsAfterSubmit. - Adds levelbuilder configuration and purpose defaults.
- Hides submitted question cards and adds coverage.
| File | Description |
|---|---|
dashboard/app/models/levels/quiz.rb |
Persists the setting. |
dashboard/app/controllers/quizzes_controller.rb |
Reads and updates the setting. |
dashboard/test/controllers/quizzes_controller_test.rb |
Tests controller handling. |
apps/src/quiz/types.ts |
Adds the level property type. |
apps/src/quiz/builder/useQuizBuilderView.tsx |
Initializes builder state. |
apps/src/quiz/builder/QuizConfigurationPanel.tsx |
Adds defaults and toggle UI. |
apps/src/quiz/attempt/useQuizAttemptView.tsx |
Passes the setting to the workspace. |
apps/src/quiz/attempt/QuizAttemptWorkspace.tsx |
Suppresses submitted question results. |
apps/test/unit/quiz/builder/QuizConfigurationPanelTest.tsx |
Tests configuration behavior. |
apps/test/unit/quiz/attempt/QuizAttemptWorkspaceTest.tsx |
Tests hidden results. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fisher-alice
changed the title
Thanks for adding these options! From a UI standpoint, I'd like to make a few tweaks around how how we divide controls within a card and how we tie the conditional to the field that triggers it. I'll update mocks to include the new option! |
Mocks have been updated! |
This PR adds the quiz config option `Show questions after submit'. Note that I changed from hide -> show to match the wording used for 'Show correctness'. Also, I moved the field directly under 'Show correctness' since both have to be turned on for 'Reveal answer and explanation' to be possible:
@moshebaricdo lmk what you think. Thanks!
Links
Testing story
Added unit tests and tested locally.
Screencast of new field and toggle in build mode:
Screen.Recording.2026-10-02.at.12.37.37.PM.mov
Screenshot of quiz when show_correctness is true but show_questions_after_submit is false.
Deployment notes
Privacy and security