Issues

Gas Optimizations

code-423n4/2022-01-insure-findings#362 · opened

on Feb 7, 2022

Gas: Avoid expensive calculation by checking if `originalLiquidity() == 0`

code-423n4/2022-01-insure-findings#361 · opened

on Jan 13, 2022

Gas: Optimize Conditional Statements in `PoolTemplate.sol:worth()`

code-423n4/2022-01-insure-findings#355 · opened

on Jan 13, 2022

1

Index compensate is 0 when totalLiquidity() is enough to cover the whole amount

code-423n4/2022-01-insure-findings#354 · opened

on Jan 13, 2022

1

Unbounded iteration over all indexes (2)

code-423n4/2022-01-insure-findings#352 · opened

on Jan 13, 2022

4

Gas: `incident.payoutDenominator` is used only once. It shouldn't be stored in a variable.

code-423n4/2022-01-insure-findings#350 · opened

on Jan 13, 2022

Gas: `incident.payoutNumerator` is used only once. It shouldn't be stored in a variable.

code-423n4/2022-01-insure-findings#349 · opened

on Jan 13, 2022

Insurance Pool Locking Does Not Propagate To All Markets

code-423n4/2022-01-insure-findings#347 · opened

on Jan 13, 2022

1

Gas: `PoolTemplate:initialize()::_conditions` should be a fixed array of size 2

code-423n4/2022-01-insure-findings#345 · opened

on Jan 13, 2022

1

Gas: Avoid expensive calculation by checking if `valueAll() == 0`

code-423n4/2022-01-insure-findings#344 · opened

on Jan 13, 2022

1

Gas: Cache `attributions[_target]` in `Vault.sol:underlyingValue()`

code-423n4/2022-01-insure-findings#343 · opened

on Jan 13, 2022

1

Pause check missing on the several functions (PoolTemplate)

code-423n4/2022-01-insure-findings#339 · opened

on Jan 13, 2022

Misleading comments and documentation

code-423n4/2022-01-insure-findings#337 · opened

on Jan 13, 2022

1

Ordering importance in a struct

code-423n4/2022-01-insure-findings#334 · opened

on Jan 13, 2022

2

Order of statements

code-423n4/2022-01-insure-findings#332 · opened

on Jan 13, 2022

2

Gas: Cache `_fee[_target]` in `Parameters.sol:getFeeRate()`

code-423n4/2022-01-insure-findings#320 · opened

on Jan 13, 2022

3

Gas Optimization: Use unchecked for safe math

code-423n4/2022-01-insure-findings#317 · opened

on Jan 13, 2022

Add a timelock to `Parameters:setFeeRate`

code-423n4/2022-01-insure-findings#315 · opened

on Jan 13, 2022

4

Validate _to is not empty

code-423n4/2022-01-insure-findings#314 · opened

on Jan 13, 2022

1

getLockup and getWithdrawable can change after withdrawalReq is initiated

code-423n4/2022-01-insure-findings#312 · opened

on Jan 13, 2022

`targetLev` can be set to 0 in `IndexTemplate:setLeverage`

code-423n4/2022-01-insure-findings#311 · opened

on Jan 13, 2022

3

Insurance NFT

code-423n4/2022-01-insure-findings#310 · opened

on Jan 13, 2022

2

deposit and _depositFrom are almost similar

code-423n4/2022-01-insure-findings#309 · opened

on Jan 13, 2022

1

Repeated math operations

code-423n4/2022-01-insure-findings#308 · opened

on Jan 13, 2022

repayDebt optimization

code-423n4/2022-01-insure-findings#307 · opened

on Jan 13, 2022

1

Navigation Menu

Repository navigation

Issues

Gas Optimizations

Gas: Avoid expensive calculation by checking if `originalLiquidity() == 0`

Gas: Optimize Conditional Statements in `PoolTemplate.sol:worth()`

Index compensate is 0 when totalLiquidity() is enough to cover the whole amount

Unbounded iteration over all indexes (2)

Gas: `incident.payoutDenominator` is used only once. It shouldn't be stored in a variable.

Gas: `incident.payoutNumerator` is used only once. It shouldn't be stored in a variable.

Insurance Pool Locking Does Not Propagate To All Markets

Gas: `PoolTemplate:initialize()::_conditions` should be a fixed array of size 2

Gas: Avoid expensive calculation by checking if `valueAll() == 0`

Gas: Cache `attributions[_target]` in `Vault.sol:underlyingValue()`

Pause check missing on the several functions (PoolTemplate)

Misleading comments and documentation

Ordering importance in a struct

Order of statements

Gas: Cache `_fee[_target]` in `Parameters.sol:getFeeRate()`

Gas Optimization: Use unchecked for safe math

Add a timelock to `Parameters:setFeeRate`

Validate _to is not empty

getLockup and getWithdrawable can change after withdrawalReq is initiated

`targetLev` can be set to 0 in `IndexTemplate:setLeverage`

Insurance NFT

deposit and _depositFrom are almost similar

Repeated math operations

repayDebt optimization