Allow repo set-default --unset without an argument - #14540
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation matches the requested behavior and includes appropriate regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Allows non-interactive gh repo set-default --unset without a repository argument, fixing #14521.
Changes:
- Exempts
--unsetfrom non-interactive repository validation. - Adds regression coverage for
--unset,--view, and ordinary invocation.
| File | Description |
|---|---|
pkg/cmd/repo/setdefault/setdefault.go |
Updates non-interactive validation. |
pkg/cmd/repo/setdefault/setdefault_test.go |
Covers affected flag and TTY behavior. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sergiou87
approved these changes
Sep 29, 2026
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14521
Description
gh repo set-default --unsetincorrectly required a repository argument when stdin was not interactive. The command does not use a repository argument when unsetting the current default.This exempts
--unsetfrom the non-interactive repository requirement, matching the existing behavior for--view. Constructor tests cover argument-free non-interactive--unsetand--viewwhile preserving the error for an ordinary argument-free non-interactive invocation.How did you test this change?
session.mp4
Key points
This change does not alter the existing acceptance of a repository argument with
--unset; deciding whether that ignored argument should be rejected is outside this fix.Notes for reviewers
Start with the non-interactive validation condition in
NewCmdSetDefault, then review the constructor test cases that distinguish--view,--unset, and ordinary invocation.Authorship and follow-up
Who wrote this:
Who answers review comments: