Revert "Use internal Apple codesign action" - #14462
Merged
williammartin merged 1 commit intoSep 15, 2026
Merged
Conversation
This reverts commit 38316c1.
babakks
approved these changes
Sep 15, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Production signing is sensitive, and this restores the Node 20-targeting action from #14411 without explaining the necessary trade-off.
Review tier: Balanced
Findings: None
What changed in this PR
Reverts #14437, restoring the previous external Apple codesigning action for production macOS releases.
Changes:
- Restores the
nodeselector/setup-apple-codesignworkflow reference. - Updates release documentation to reference the external action.
| File | Description |
|---|---|
.github/workflows/deployment.yml |
Restores the external codesigning action. |
docs/release-process-deep-dive.md |
Restores the corresponding documentation. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
williammartin
enabled auto-merge
September 15, 2026 14:05
williammartin
deleted the
revert-14437-williammartin-apple-codesign-action
branch
September 15, 2026 14:11
1 task
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts #14437
Failed https://github.com/cli/cli/actions/runs/34978056515/job/104410855926
https://docs.github.com/en/enterprise-cloud@latest/actions/how-tos/reuse-automations/share-with-your-enterprise