Recognize maintainer authorization - #14438
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Trusted maintainer authorization or eligible issue context has not been established.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced (auto)
Findings: 1
Note
Copilot is running an experiment and ran this review at Balanced.
Open findings (1)
What changed in this PR
Clarifies when maintainer permissions constitute trusted authorization.
Changes:
- Recognizes authenticated
maintainoradminpermission. - Retains trusted-context requirements for other cases.
| File | Description |
|---|---|
AGENTS.md |
Updates external-contribution authorization guidance. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The repository guidance currently says maintainer authorization must come from trusted context, but it does not identify authenticated repository permission as sufficient evidence. This clarifies that agents should check trusted context before applying the external-contributor gate and that an authenticated GitHub identity with at least
writepermission oncli/cliauthorizes work requested by that user.How did you test this change?
I ran
git diff --check trunk...HEADand saw no whitespace errors. I inspectedgit diff --name-status trunk...HEADand saw that onlyAGENTS.mdis modified, then reviewed the complete diff.Key points
This treats authenticated permission of at least
writeas sufficient authorization becausecli/cligrants that access to trusted maintainers, while retaining the existing trusted-context requirement for all other cases.Notes for reviewers
Review the external contribution gate in
AGENTS.md, especially the new permission-based authorization wording.Authorship and follow-up
Who wrote this:
Who answers review comments: