Skip to content

Modernize Go code with go fix #14278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BagToad merged 26 commits into from
Aug 27, 2026
Merged

Modernize Go code with go fix #14278

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
e954245
Replace interface{} with any
BagToad Aug 26, 2026
abdea37
Use fmt.Appendf for byte formatting
BagToad Aug 26, 2026
4f0eb3d
Use maps helpers for map loops
BagToad Aug 26, 2026
aee884d
Use min and max built-ins
BagToad Aug 26, 2026
3f7bb81
Use new expression syntax
BagToad Aug 26, 2026
8a63c38
Use omitzero JSON tags
BagToad Aug 26, 2026
e26caf1
Use integer range loops
BagToad Aug 26, 2026
83c1649
Use reflect.TypeFor
BagToad Aug 26, 2026
6f844ce
Use slices.Contains helpers
BagToad Aug 26, 2026
fdd5a07
Use standard library iterators
BagToad Aug 26, 2026
fc68dc4
Use strings.Builder for concatenation
BagToad Aug 26, 2026
d190d6a
Use strings.Cut
BagToad Aug 26, 2026
4cf0c4e
Use strings.CutPrefix
BagToad Aug 26, 2026
f0f3646
Use string sequence iterators
BagToad Aug 26, 2026
556199d
Use testing context helper
BagToad Aug 26, 2026
ecb8c5a
Use WaitGroup.Go
BagToad Aug 26, 2026
0b23d8d
Inline duration pointer helper
BagToad Aug 26, 2026
b3846d7
Apply remaining strings.Builder fix
BagToad Aug 26, 2026
981de3e
Run go fix in lint workflow
BagToad Aug 26, 2026
6ba9230
Remove inlined pointer helpers
BagToad Aug 26, 2026
e86515a
Remove obsolete reflection helper
BagToad Aug 26, 2026
07fb593
Use native Go diff checks
BagToad Aug 27, 2026
10f0ee3
Simplify skill processing limit
BagToad Aug 27, 2026
a0b4ede
Simplify auth host validation
BagToad Aug 27, 2026
4c32c17
Inline codespace slice checks
BagToad Aug 27, 2026
88684c2
Inline pull request slice checks
BagToad Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Inline codespace slice checks 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
  • Loading branch information
@BagToad
BagToad and Copilot committed Aug 27, 2026
commit 4c32c17116eee7947aa8e2e4e298ff0032d2a5a6
8 changes: 2 additions & 6 deletions pkg/cmd/codespace/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,12 +245,12 @@ func (a *App) Create(ctx context.Context, opts createOptions) error {
if len(devcontainers) > 0 {

// if there is only one devcontainer.json file and it is one of the default paths we can auto-select it
if len(devcontainers) == 1 && stringInSlice(devcontainers[0].Path, DEFAULT_DEVCONTAINER_DEFINITIONS) {
if len(devcontainers) == 1 && slices.Contains(DEFAULT_DEVCONTAINER_DEFINITIONS, devcontainers[0].Path) {
devContainerPath = devcontainers[0].Path
} else {
promptOptions := []string{}

if !stringInSlice(devcontainers[0].Path, DEFAULT_DEVCONTAINER_DEFINITIONS) {
if !slices.Contains(DEFAULT_DEVCONTAINER_DEFINITIONS, devcontainers[0].Path) {
promptOptions = []string{DEVCONTAINER_PROMPT_DEFAULT}
}

Expand Down Expand Up @@ -604,7 +604,3 @@ func buildDisplayName(displayName string, prebuildAvailability string) string {
return displayName
}
}

func stringInSlice(a string, slice []string) bool {
return slices.Contains(slice, a)
}