Fix Copilot declined-install warning newline - #14222
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes terminal formatting when users decline Copilot CLI installation.
Changes:
- Adds the missing warning newline.
- Consolidates run behavior and telemetry coverage into table-driven tests.
Show a summary per file
| File | Description |
|---|---|
pkg/cmd/copilot/copilot.go |
Terminates the declined-install warning with a newline. |
pkg/cmd/copilot/copilot_test.go |
Verifies exact warning output and consolidates existing tests. |
Review details
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
babakks
approved these changes
Aug 21, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14189
Description
When
gh copilotcannot find Copilot CLI and installation is declined, its warning does not end with a newline. This leaves the next shell prompt on the same line.Add a trailing newline to the warning and cover its exact output in the primary run-function table test.
While adding that coverage, consolidate the existing execution-failure test into the run-function table and move the telemetry sampling assertion into the constructor table. This keeps command-level behavior in the two primary table tests.
How did you test this change?
Given Copilot CLI was excluded from
PATH, when I ran a locally builtgh copilotin a terminal and declined installation, then the warning and following shell marker appeared on separate lines:Key points
Notes for reviewers
Start with the declined-install branch, then review its output case in the run-function table. Issue #14189 contains the original terminal reproduction.
Authorship and follow-up
Who wrote this:
Who answers review comments: