Skip to content

Don't ask for feature detection cleanup comments when not needed #14139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
babakks merged 2 commits into from
Aug 13, 2026
Merged

Don't ask for feature detection cleanup comments when not needed #14139

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3107015
Update AGENTS.md with cleanup comment guidance
babakks Aug 13, 2026
508510f
Reconcile feature detection cleanup comment rules in AGENTS.md
Copilot Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ if features.SomeCapability {

Use feature detection only when an API is not GA on all supported GHES versions; skip it for long-established APIs.

Note that a cleanup comment is only needed when a feature will eventually be available on all GitHub API server (i.e. `github.com`, GHEC, and GHES). Those that are not going to be supported on GHES should not have a cleanup comment.

@babakks babakks Aug 13, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Fix the code for this review comment.

When a review comment includes a suggested change, apply the suggestion exactly.

Do not make changes beyond what is described in the linked review comment.

Copilot AI Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 508510f - merged the two rules into one consistent statement: the cleanup TODO is required for temporary gates and not needed for permanent GHES-excluded gates.


## API Patterns

```go
Expand Down