Skip to content

Route release deletions through api.Client #14077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
williammartin merged 8 commits into from
Aug 6, 2026
Merged

Route release deletions through api.Client #14077

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2ec12d3
Route release edits through api.Client
williammartin Jul 28, 2026
55ad01b
Defer release edit api.Client migration
williammartin Aug 4, 2026
0b9f913
Add release deletion acceptance test
williammartin Aug 5, 2026
e04f041
Remove release deletion test delay
williammartin Aug 5, 2026
b049378
Tighten release deletion assertion
williammartin Aug 5, 2026
4ff7de2
Wait for release tag consistency
williammartin Aug 5, 2026
52c766c
Use http method
williammartin Aug 5, 2026
28ebaf1
Merge pull request #14078 from cli/williammartin-route-run-artifacts-…
williammartin Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add release deletion acceptance test 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: cd6661ad-7e77-46d0-b0e7-0a296f4e252b
  • Loading branch information
@williammartin
williammartin and Copilot committed Aug 5, 2026
commit 0b9f913f469538035e06bdd25cbbbb5845a7191c
38 changes: 38 additions & 0 deletions acceptance/testdata/release/release-delete.txtar
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# Create a repository with a file so it has a default branch
exec gh repo create $ORG/$SCRIPT_NAME-$RANDOM_STRING --add-readme --private

# Defer repo cleanup
defer gh repo delete --yes $ORG/$SCRIPT_NAME-$RANDOM_STRING

# Create a release in the repo
exec gh release create v1.2.3 --repo $ORG/$SCRIPT_NAME-$RANDOM_STRING --notes 'awesome release' --latest

# Upload an asset to the release
exec gh release upload v1.2.3 --repo $ORG/$SCRIPT_NAME-$RANDOM_STRING asset.txt

# Delete the asset from the release
exec gh release delete-asset v1.2.3 asset.txt --repo $ORG/$SCRIPT_NAME-$RANDOM_STRING --yes

# Verify the release has no assets
exec gh release view v1.2.3 --repo $ORG/$SCRIPT_NAME-$RANDOM_STRING --json assets --jq '.assets | length'
stdout '0'

# Downloading the deleted asset should fail
! exec gh release download v1.2.3 --repo $ORG/$SCRIPT_NAME-$RANDOM_STRING
stderr 'no assets to download'

# Delete the release and its tag
exec gh release delete v1.2.3 --repo $ORG/$SCRIPT_NAME-$RANDOM_STRING --yes --cleanup-tag

# Give the tag cleanup time to propagate
sleep 5

# Verify the release is gone
! exec gh release view v1.2.3 --repo $ORG/$SCRIPT_NAME-$RANDOM_STRING

# Verify the tag is gone
! exec gh api repos/$ORG/$SCRIPT_NAME-$RANDOM_STRING/git/ref/tags/v1.2.3
stderr 'Not Found'

-- asset.txt --
Hello, world!