Skip to content

Fix project item-add output for non-TTY #14056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
babakks merged 4 commits into from
Aug 10, 2026
Merged

Fix project item-add output for non-TTY #14056

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6bcd08
Fix item-add output for non-TTY
zwick Aug 3, 2026
ec913e6
Test item-add output through command path
zwick Aug 7, 2026
27a114d
Isolate item-add test mocks
zwick Aug 7, 2026
0e47daf
Reduce item-add test diff
zwick Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pkg/cmd/project/item-add/item_add.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,11 @@ func addItemArgs(config addItemConfig) (*addProjectItemMutation, map[string]inte
}

func printResults(config addItemConfig, item queries.ProjectItem) error {
if !config.io.IsStdoutTTY() {
return nil
if config.io.IsStdoutTTY() {
_, err := fmt.Fprintln(config.io.Out, "Added item")
return err
}

_, err := fmt.Fprintf(config.io.Out, "Added item\n")
_, err := fmt.Fprintln(config.io.Out, item.Id)
Comment thread
zwick marked this conversation as resolved.
return err
}
32 changes: 32 additions & 0 deletions pkg/cmd/project/item-add/item_add_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"github.com/cli/cli/v2/pkg/iostreams"
"github.com/google/shlex"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gopkg.in/h2non/gock.v1"
)

Expand Down Expand Up @@ -539,3 +540,34 @@ func TestRunAddItem_JSON(t *testing.T) {
`{"id":"item ID","title":"a title","body":"","type":"Issue"}`,
stdout.String())
}

func TestPrintResults(t *testing.T) {
Comment thread
zwick marked this conversation as resolved.
Outdated
tests := []struct {
name string
stdoutTTY bool
want string
}{
{
name: "tty",
stdoutTTY: true,
want: "Added item\n",
},
{
name: "non-tty",
want: "item ID\n",
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
ios, _, stdout, _ := iostreams.Test()
ios.SetStdoutTTY(tt.stdoutTTY)
config := addItemConfig{io: ios}

err := printResults(config, queries.ProjectItem{Id: "item ID"})

require.NoError(t, err)
assert.Equal(t, tt.want, stdout.String())
})
}
}