feat(mosaic): prototype an internal modal host with useUserProfileModal - #9998
Draft
alexcarpenter wants to merge 6 commits into
Draft
alexcarpenter wants to merge 6 commits into
alexcarpenter wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: d5cb0af The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prototype of how Mosaic could manage modals, starting with UserProfile. This is internal plumbing only: nothing new is exported from
@clerk/mosaic,MosaicProvidergains no props, and the exportedUserButtonis unchanged (it still callsclerk.openUserProfile).useUserProfileModal(config)→{ open(payload?), close(), preload(), isOpen }.MosaicProvidermounts an internal modal host, so neither components nor apps render dialogs themselves.preload()warms it (e.g. on hover), and a failed load shows a retry inside the dialog instead of taking down the app.open({ page })re-seeds the content, so callers can deep-link into a page.MosaicProviderprop is left as anit.todo.The UserProfile content uses static demo data. Try it in swingset on the UserButton page, under "Profile modal": "Manage account", "Open security" and "Open integrations" (a custom page) all open the same modal.
Known gaps before this could be public: localized loading/error text, an accessible dialog name while loading, forwarding the remaining profile props, and moving the organization profile and create-organization modals onto the host.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change