Repository navigation
Update particle speed calculation to be more robust against round-off error - #1917
Merged
Merged
Conversation
Remove check for zero speed in `TimeUpdater` and update tests.
amandalund
added
physics
Test summary 4 572 files 7 281 suites 13m 18s ⏱️ Results for commit 61457f5. |
sethrj
approved these changes
Aug 28, 2025
sethrj
enabled auto-merge (squash)
August 28, 2025 15:14
Member
|
@amandalund Thanks! I tightened one of the tests to check that the |
sethrj
pushed a commit
that referenced
this pull request
Sep 13, 2025
… error (#1917) * Add low energy particle speed test * Use an expression for speed that is robust against round-off error Remove check for zero speed in `TimeUpdater` and update tests. * Check exact equality for photon properties
sethrj
pushed a commit
to sethrj/celeritas
that referenced
this pull request
Sep 13, 2025
… error (celeritas-project#1917) * Add low energy particle speed test * Use an expression for speed that is robust against round-off error Remove check for zero speed in `TimeUpdater` and update tests. * Check exact equality for photon properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the suggestion in openmc-dev/openmc#3526 (review), this modifies the calculation of the particle speed to use an expression that's less susceptible to round-off errors.