Skip to content

Retry on empty addition #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szmania wants to merge 9 commits into
base: v1.6.2
Choose a base branch
from
Open

Retry on empty addition #702

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c9d3d14
cli-65: retry config fix
Sep 26, 2026
75ce809
update
Sep 26, 2026
7e60027
cli-65: update linting
Sep 26, 2026
8100780
merged
Sep 26, 2026
52c0b36
feat: implement retry-on-forbidden feature
Sep 26, 2026
8999518
style: fix formatting of retry_on_forbidden assignment
Sep 27, 2026
25505e9
cli-67: retry on empty addition
Sep 29, 2026
f82edcb
cli-67: retry on empty addition
Sep 29, 2026
e3107a0
fixed linting
Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: implement retry-on-forbidden feature
  • Loading branch information
Your Name
Your Name committed Sep 26, 2026
commit 52c0b3605c626cebeff00061d69bc2dbe18d8373
2 changes: 2 additions & 0 deletions cecli/coders/base_coder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2860,6 +2860,8 @@ async def format_in_executor():
should_retry = ex_info.retry
if ex_info.name == "ServiceUnavailableError":
should_retry = should_retry or retry_config["retry_on_unavailable"]
if ex_info.name == "PermissionDeniedError":
should_retry = should_retry or retry_config["retry_on_forbidden"]

if should_retry:
retry_delay *= retry_config["retry_backoff_factor"]
Expand Down
11 changes: 11 additions & 0 deletions cecli/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ class ModelSettings:
retries: Optional[dict] = None
retry_backoff_factor: float = 1.5
retry_on_unavailable: bool = True
retry_on_forbidden: bool = False
retry_timeout: float = 30
request_timeout: int = request_timeout
debug: bool = False
Expand Down Expand Up @@ -1463,6 +1464,9 @@ async def send_completion(
self.retry_on_unavailable = bool(
nested.getter(retry_config, "retry-on-unavailable", True)
)
self.retry_on_forbidden = bool(
nested.getter(retry_config, "retry-on-forbidden", False)
)
self.retry_backoff_factor = float(
nested.getter(retry_config, "retry-backoff-factor", 1.5)
)
Expand Down Expand Up @@ -1497,6 +1501,8 @@ async def send_completion(
should_retry = ex_info.retry
if ex_info.name == "ServiceUnavailableError":
should_retry = should_retry or self.retry_on_unavailable
elif ex_info.name == "PermissionDeniedError":
should_retry = should_retry or self.retry_on_forbidden

custom_retry_delay = self._extract_retry_delay(err)
if custom_retry_delay is not None:
Expand Down Expand Up @@ -1561,6 +1567,7 @@ async def simple_send_with_retries(
retry_backoff_factor = retry_config["retry_backoff_factor"]
retry_timeout = retry_config["retry_timeout"]
retry_on_unavailable = retry_config["retry_on_unavailable"]
retry_on_forbidden = retry_config["retry_on_forbidden"]

if self.verbose:
dump(messages)
Expand Down Expand Up @@ -1614,6 +1621,8 @@ async def simple_send_with_retries(
should_retry = ex_info.retry
if ex_info.name == "ServiceUnavailableError":
should_retry = should_retry or retry_on_unavailable
elif ex_info.name == "PermissionDeniedError":
should_retry = should_retry or retry_on_forbidden

custom_retry_delay = self._extract_retry_delay(err)
if custom_retry_delay is not None:
Expand Down Expand Up @@ -1807,6 +1816,7 @@ def parse_retry_config(retries_input):
retry_timeout: 30
retry_backoff_factor: 1.5
retry_on_unavailable: True
retry_on_forbidden: False
retry_on_empty: False
"""
config = dict()
Expand All @@ -1832,6 +1842,7 @@ def _get(key, default):
"retry_timeout": float(_get("retry_timeout", 30)),
"retry_backoff_factor": float(_get("retry_backoff_factor", 1.5)),
"retry_on_unavailable": bool(_get("retry_on_unavailable", True)),
"retry_on_forbidden": bool(_get("retry_on_forbidden", False)),
"retry_on_empty": bool(_get("retry_on_empty", False)),
}

Expand Down
Loading