Fix |phpversion| rendering literally as **8.5** in Docker commands; update installation.md too - #8344
Merged
Merged
Conversation
Follow-up to cakephp#8343. The |phpversion| substitution is configured with format: 'bold', which wraps the value in markdown ** syntax. That's fine in prose, but markdown-it doesn't process inline markdown inside fenced code blocks, so readers saw the literal text "ghcr.io/cakephp/cakephp:**8.5**" instead of a working image tag. Pinned the tag to 8.5 directly in both Docker commands on the homepage instead (same convention the Docker block already used before, where the PHP version was hardcoded as php:8.2-cli). Also updated the Docker section (Method 3) on the installation page to the same ghcr.io/cakephp/cakephp image, since it had the identical underlying bugs (missing intl/pdo_mysql, apt-get installing extensions at runtime, "php bin/cake" instead of "php bin/cake.php"). Grepped the rest of docs/ for other docker run / php:8.x examples; these two pages were the only ones referencing CakePHP's own Docker setup. Verified both updated commands end to end again with real `docker run`: composer create-project and the dev server both work against ghcr.io/cakephp/cakephp:8.5, welcome page returns HTTP 200.
Avoids hardcoding 8.5 directly in the Docker commands (which would need manual updates across both pages every time the documented PHP version bumps). Adds |phpdockerversion| as a plain, unformatted substitution (same pattern as |cakeversion|) alongside the existing bold-formatted |phpversion| used in prose, so the two don't conflict.
Member
|
Thank you 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8343, addressing @LordSimal's two comments there:
Pinned the tag to
8.5directly instead.Updated
docs/en/installation.md's "Method 3: Docker" section to the sameghcr.io/cakephp/cakephpimage.