Skip to content

perf: cranelift-codegen-meta: less llvm-lines: strings.join(" ") and iterators - #14127

Draft
dishmaker wants to merge 1 commit into
bytecodealliance:mainfrom
dishmaker:dishmaker/perf_cc_meta_displayjoin
Draft

dishmaker wants to merge 1 commit into
bytecodealliance:mainfrom
dishmaker:dishmaker/perf_cc_meta_displayjoin

Conversation

@dishmaker

Copy link
Copy Markdown
Contributor

-2.2% llvm lines

  • added DisplayJoined
  • simplified iterator combinators: .chain(...)
  • use format_args! in fmt.add_block calls

This PR might be controversial, because anywhere in the code just one:

  • strings.join(" ") instead of
  • strings.display_join(" ")

adds back the 1254 llvm-lines that I managed to remove 😐
(but that's still a -1.5% win).

@github-actions github-actions Bot added cranelift Issues related to the Cranelift code generator cranelift:meta Everything related to the meta-language. labels Aug 12, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift:meta Everything related to the meta-language. cranelift Issues related to the Cranelift code generator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant