Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please sign CLA and add your name to contributors list. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5764043340
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "delete-active-confirmation": "Instance ini masih aktif. Hapus tetap?", | ||
| "delete-confirmation": "Apakah Anda yakin ingin menghapus instance ini?", |
There was a problem hiding this comment.
These delete-confirmation translations drop both {{name}} and {{id}}, but InstanceDeleteDialog still requires the user to type the exact instance ID before the destructive action is enabled. In Indonesian the dialog no longer tells users which ID to enter or that the named instance is being permanently deleted; the same placeholder mismatch pattern appears elsewhere in this new file, so the translated strings need to keep the original interpolation token names exactly.
Useful? React with 👍 / 👎.
|
I have signed the CLA. Could you please re-trigger the CLA check? |
|
The GitHub CLA Bot is rechecking to see that you have signed the CLA |
|
We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please sign CLA and add your name to contributors list. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d772ccd6e1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please sign CLA and add your name to contributors list. |
1 similar comment
|
We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please sign CLA and add your name to contributors list. |
7dd042f to
948e861
Compare
|
We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please sign CLA and add your name to contributors list. |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 948e861515
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| subscription: esESSubscription, | ||
| }), | ||
| }, | ||
| "id-ID": { |
There was a problem hiding this comment.
Registering id-ID as a runtime locale here leaves the CI locale guard behind: pnpm --dir frontend check runs frontend/scripts/check-react-i18n.mjs, but that script still hard-codes LOCALES = ["en-US", "zh-CN", "es-ES", "ja-JP", "vi-VN"]. As a result, missing/extra keys and interpolation syntax errors in the new Indonesian files won't fail the standard frontend check; I confirmed the new locale already contains unchecked placeholder mismatches such as settings.members.select-account_* using {{n}} while callers pass count. Please include id-ID in the checker alongside registering it in the runtime resources.
Useful? React with 👍 / 👎.
This branch has not been deployed
1 participant
Summary
Add Indonesian (id-ID) locale support for Bytebase frontend.
Changes
Testing