Conversation
Do search of only disabled users: see that enabled users are still listed. Then apply patch and retry.
|
@dylanwh Any reason not to merge this? Also (and this may open a can of worms) why is this code not in a separate module so it can be tested, rather than bundled up in a not-very-testable |
Author
|
Coincidentally, I was just looking at our in-house version of this pull request & wondering about it. |
Author
|
cough |
Author
|
7 months later, another cough |
Author
|
7 months later. |
justdave
pushed a commit
to justdave/bugzilla
that referenced
this pull request
May 6, 2024
This is a Mozilla-specific field which has not been properly
encapsulated into the BMO extension, where most of its implementation
lies.
Remove the hard-coded references occurring outside the BMO extension.
This fixes an internal error ("Can't use cf_crash_signature as a field
name.").
Co-authored-by: Dylan Hardison <dylan@hardison.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do search of only disabled users: see that enabled users are still listed. Then apply patch and retry.