[5.0.4] Bug 681635: De-duplicate values in Advanced Search - #245
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
justdave
self-requested a review
September 1, 2026 03:25
justdave
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Advanced Search can show duplicate version or target milestone values when selected products use configured ordering rather than case-insensitive alphabetical ordering.
merge_arraysused a two-pointer merge that assumed both inputs were already sorted, so overlapping values at different positions were not recognized as duplicates.This is the
5.0.4port of #244. It combines both inputs, sorts them case-insensitively, and then removes adjacent case-insensitive duplicates while preserving the incremental path that merges existing<select>options. A Perl TAP regression test executes the production JavaScript with Node and fails clearly if Node is unavailable.Additional info
Test Plan
node --check js/productform.js.perl runtests.pl 15.