Skip to content

update versioneer #235

Closed
Closed

Description

@prjemian

Confirm if updates to versioneer support is necessary. (Note similar PR bluesky/hkl-notebooks#4) with these remarks:

SafeConfigParser has been deprecated since Python 3.2 and will be removed in py312.

python/cpython#28292
https://bugs.python.org/issue45173
python/cpython#89336

Similar code exists now in hklpy:

parser = configparser.SafeConfigParser()

Activity

  1. added this to the v1.1 milestone on Jun 22, 2022
  2. self-assigned this
    on Jun 22, 2022
  3. prjemian commented on Jun 22, 2022

    @prjemian
    ContributorAuthor

    See: Updating Versioneer

    • install the new Versioneer (pip install -U versioneer or equivalent)
    • edit setup.cfg, if necessary, to include any new configuration settings indicated by the release notes. See UPGRADING for details.
    • re-run versioneer install in your source tree, to replace SRC/_version.py
    • commit any changed files
  4. prjemian commented on Jun 22, 2022

    @prjemian
    ContributorAuthor
    (dev-hklpy) prjemian@zap:~/.../Bluesky/hklpy$ versioneer install 
    replacing old versioneer.py (0.15)
    versioneer.py (0.22) installed into local tree
    Now running 'versioneer.py setup' to install the generated files..
     creating hkl/_version.py
     appending to hkl/__init__.py
     'versioneer.py' already in MANIFEST.in
     versionfile_source already in MANIFEST.in
  5. added a commit that references this issue on Jun 22, 2022
  6. prjemian commented on Jun 22, 2022

    @prjemian
    ContributorAuthor

    These changes include the principle change implemented in PR bluesky/hkl-notebooks#4:

        parser = configparser.ConfigParser()

    This additional change remains to replace the two lines following:

        parser.read(setup_cfg)
  7. added a commit that references this issue on Jun 22, 2022
  8. modified the milestones: v1.2, v1.1 on Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions