Skip to content

Fix CATH downloads: use https, and check the response before caching it #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aalhossary wants to merge 4 commits into from
+923 −92
Closed

Fix CATH downloads: use https, and check the response before caching it #1136

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f061f57
Fix FileDownloadUtils validation and implement checksum verification
aalhossary Aug 15, 2026
80e9daa
Test that a 404 is neither cached nor recorded as valid
aalhossary Aug 15, 2026
66d27c7
Make LocalPDBDirectory.getLastModifiedTime public
aalhossary Aug 15, 2026
7244f21
Fix CATH downloads: use https, and check the response before caching it
aalhossary Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make LocalPDBDirectory.getLastModifiedTime public 
It is a general 'has the server got a newer copy' helper with nothing
PDB-specific about it, and other caching code outside this package needs the
same Last-Modified comparison. Protected access only reached subclasses and
the io package itself.
  • Loading branch information
@aalhossary
aalhossary committed Aug 15, 2026
commit 66d27c77a427f82812a2e05f5338a33b0b4d14f6
3 changes: 2 additions & 1 deletion biojava-structure/src/main/java/org/biojava/nbio/structure/io/LocalPDBDirectory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,8 +612,9 @@ public static String getMiddleHash(String pdbId) {
* Note that this only works for http URLs
* @param url
* @return the last modified date or null if it couldn't be retrieved (in that case a warning will be logged)
* @since 7.3.0 made public so that other caching code can reuse it
*/
protected static Date getLastModifiedTime(URL url) {
public static Date getLastModifiedTime(URL url) {

// see http://stackoverflow.com/questions/2416872/how-do-you-obtain-modified-date-from-a-remote-file-java
Date date = null;
Expand Down
Loading