Repository navigation
Issue 1038 - Test was refactored by using junit5 features - #1125
Merged
josemduarte merged 1 commit intoAug 26, 2026
Merged
Conversation
Contributor
|
In principle this looks good, thank you. However we currently have an issue with tests (due to a failing external resource used during testing) that we'd like to fix before going with this junit5 refactoring. |
josemduarte
approved these changes
Aug 26, 2026
josemduarte
left a comment
josemduarte
left a comment
Contributor
There was a problem hiding this comment.
LGTM thanks. Tried the tests locally and they worked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 1038 - Test was refactored by using junit5 features.
The next step should be converting other tests in the module to JUnit5