Skip to content

Add == gotcha that can be unintuitive at first #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tenderlove merged 1 commit into from
Oct 29, 2024
Merged

Add == gotcha that can be unintuitive at first #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add == gotcha that can be unintuitive at first
  • Loading branch information
@federicoaldunate
federicoaldunate committed Jul 14, 2024
commit ff9084a3f5e993b1ba9609e2326494fd97db61dc
2 changes: 2 additions & 0 deletions lib/bcrypt/password.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ def initialize(raw_hash)
# @password == @password.to_s # => False
# @password.to_s == @password # => True
# @password.to_s == @password.to_s # => True
#
# secret == @password # => probably False, because the secret is not a BCrypt::Password instance.
def ==(secret)
super(BCrypt::Engine.hash_secret(secret, @salt))
end
Expand Down