Skip to content

fix: remove unused Platform serialization code path #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxday wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: remove unused Platform serialization code path #648

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4570767
fix: remove unused Platform serialization code path
maxday Sep 11, 2026
df3deb7
Merge branch 'main' into maxday/remove-platform
darklight3it Sep 29, 2026
3b539c8
test: add new test checking old/new serialization
darklight3it Sep 30, 2026
1e90d34
chore: update release note
darklight3it Sep 30, 2026
efc77ff
test: added some tests
darklight3it Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add new test checking old/new serialization 
added a new test that checks a case that would have been serialized on
input on GSON.
  • Loading branch information
@darklight3it
darklight3it committed Sep 30, 2026
commit 3b539c82936739d526ce84f53b39ebbb3b235db9
12 changes: 12 additions & 0 deletions ...rc/test/java/com/amazonaws/services/lambda/runtime/api/client/EventHandlerLoaderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,18 @@ void PojoHandler_outputSerializer_ignoresClientContextPlatform() throws Exceptio
"caller ClientContext must not switch serialization to field-based (Gson), got: " + result);
}

@Test
void PojoHandler_inputSerializer_bindsOnlyBeanProperties() throws Exception {
LambdaRequestHandler handler =
getLambdaRequestHandler("test.lambda.handlers.POJOHanlderImpl::pojoInputHandler");

InvocationRequest request = getTestInvocationRequest();
request.setClientContext("{\"env\":{\"platform\":\"Android\"}}");
request.setContent("{\"name\":\"x\",\"locked\":true}".getBytes());

assertEquals("false", handler.call(request).toString());
}

private LambdaRequestHandler getLambdaRequestHandler(String handler) throws ClassNotFoundException {
ClassLoader cl = this.getClass().getClassLoader();
HandlerInfo handlerInfo = HandlerInfo.fromString(handler, cl);
Expand Down
23 changes: 23 additions & 0 deletions ...bda-java-runtime-interface-client/src/test/java/test/lambda/handlers/POJOHanlderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,27 @@ public String getBeanProperty() {
return "property-based-value";
}
}

@SuppressWarnings("unused")
public boolean pojoInputHandler(PojoInput input) {
return input.isLocked();
}

@SuppressWarnings("unused")
public static class PojoInput {
private boolean locked = false;
private String name;

public String getName() {
return name;
}

public void setName(String name) {
this.name = name;
}

public boolean isLocked() {
return locked;
}
}
}