fix(playwright): fractional clicks, geolocation accuracy, stale frames, wire headers and console handles - #464
Merged
Conversation
…s, wire headers and console handles Running a long script assembled from public Playwright examples on pydoll.playwright surfaced five gaps against Playwright 1.63: - Mouse coordinates were rounded to whole pixels, so a 1x1 target at a fractional offset (TodoMVC's toggle-all checkbox) was missed by check(). - Emulation.setGeolocationOverride without an accuracy makes Chrome answer POSITION_UNAVAILABLE; the context option and set_geolocation() now default it to 0 like Playwright. - Chrome does not announce the child frames of a document that a navigation replaced, so page.frames kept listing iframes from the previous page; a frame navigation now detaches its known descendants. - requestWillBeSentExtraInfo and responseReceivedExtraInfo were ignored, so all_headers(), header_value(), header_values() and headers_array() missed cookie and set-cookie; headers stays provisional like Playwright. - Console arguments passed by value used a private stand-in the sync facade never wrapped, so args[0].json_value() returned a coroutine; they now come from the frame's handle factory, and ConsoleMessage.text previews plain objects and arrays instead of printing Object. Each fix carries an integration test.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (12)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running a long script assembled from public Playwright examples on pydoll.playwright surfaced five gaps against Playwright 1.63:
Each fix carries an integration test.
Summary by CodeRabbit