Skip to content

Simbad: refactor to use TAP #2954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsipocz merged 28 commits into from
Jun 20, 2024
Merged

Simbad: refactor to use TAP #2954

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
6de7ce5
refactor: simbad query methods now call query_tap internally
ManonMarchand Feb 20, 2024
e133042
lint: add yacc and lex automatically generated files to flake8 ignore
ManonMarchand Feb 20, 2024
506fe36
fix: add a __call__ definition to make BaseVOQuery behave as BaseQuery
ManonMarchand Feb 20, 2024
879bcef
add query_criteria_fialds.json
ManonMarchand Feb 20, 2024
43a791d
docs: document simbad refactoring
ManonMarchand Feb 20, 2024
bfbbc77
fix: propagate simbad changes to jwst module
ManonMarchand Feb 21, 2024
afaddfc
docs: propagate simbad changes into the general documentation
ManonMarchand Feb 21, 2024
cf88d47
docs: simbad cache works differently now
ManonMarchand Feb 21, 2024
c961fd7
tests: add simbad_output_options to path_tests
ManonMarchand Feb 22, 2024
d892a45
refactor: remove utilities for the former sim script queries
ManonMarchand Mar 25, 2024
198cdeb
feat: add bibcodelist to possible outputs
ManonMarchand Mar 25, 2024
6088f25
test: complete coverage of simbad utils
ManonMarchand Mar 25, 2024
a7c07b4
tests: improve coverage for the tests without remote access
ManonMarchand Mar 27, 2024
650595f
docs: update simbad's doc
ManonMarchand Mar 28, 2024
2a5eff3
fix: typo in vizier link
ManonMarchand Mar 28, 2024
95232f2
feat: add ROW_LIMIT as a settable property
ManonMarchand Apr 8, 2024
91789f1
rename 'add_to_output' into 'add_output_columns'
ManonMarchand Apr 16, 2024
3f3d52b
docs: edit version of deprecation
ManonMarchand Apr 16, 2024
a795f82
feat: reduce API changes
ManonMarchand Jun 3, 2024
34000cf
docs: edits on votable fields utils
ManonMarchand Jun 3, 2024
aacd4ae
docs: add changelog
ManonMarchand Jun 3, 2024
e804139
fix: rename typed_id into user_specified_id
ManonMarchand Jun 4, 2024
82d6d2e
feat: add get_query_payload for the methods using TAP
ManonMarchand Jun 5, 2024
b87c23d
fix: wildcards in query_objects
ManonMarchand Jun 14, 2024
4534b22
docs: edit docstring and changelog from review
ManonMarchand Jun 17, 2024
7c51ec9
tests: new measurement for sirius rotation
ManonMarchand Jun 20, 2024
86ed0d7
refactor: remove Column and Join from SimbadClass
ManonMarchand Jun 20, 2024
6594ebb
DOC: minor changelog rephrase and reformat
bsipocz Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: add get_query_payload for the methods using TAP
  • Loading branch information
@ManonMarchand @bsipocz
ManonMarchand authored and bsipocz committed Jun 20, 2024
commit 82d6d2ebd368c1972445d363237efd62c00b609c
8 changes: 5 additions & 3 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,11 @@ simbad
- ``get_votable_fields`` now prints the table name and column name instead of just the
column name [#2954]

- all query methods now accept ``get_adql`` boolean argument that returns the ADQL string
instead of sending the request to SIMBAD. The ``verbose`` and ``get_query_payload``
are removed from all methods [#2954]
- The ``verbose`` and ``cache`` arguments are removed from all methods as they don't work

@bsipocz bsipocz Jun 14, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these will need to be deprecated to minimize unnecessary user code breakages. They should receive a warning rather than an exception for now.

with the new query interface [#2954]

- ``get_adql`` is replaced by ``get_query_payload`` in ``list_columns`` and ``list_table``.

@bsipocz bsipocz Jun 14, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it needs to be put through a deprecation period, too

The payload output contains the ADQL under the ``QUERY`` key [#2954]

- all query methods except ``query_tap`` and ``query_criteria`` now accept a ``criteria``
argument to restrict the results with custom criteria [#2954]
Expand Down
Loading