Skip to content

Replace custom stale bot with actions/stale - #20535

Open
pllim wants to merge 4 commits into
astropy:mainfrom
pllim:unstale-my-bot
Open

Replace custom stale bot with actions/stale#20535
pllim wants to merge 4 commits into
astropy:mainfrom
pllim:unstale-my-bot

Conversation

@pllim

@pllim pllim commented Oct 2, 2026

Copy link
Copy Markdown
Member

Description

This pull request is to replace a custom bot I wrote long time ago with a more standard actions/stale that is also used by sunpy.

Fixes #20478

AI Disclosure

If AI tools were used to develop this pull request, describe the tools including specific model and version, how they were used, and what content is AI generated. Otherwise enter "N/A".

N/A

  • I certify that I am human and that I take full responsibility for this pull request including all interactions with reviewers.

Merge method

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added this to the v8.1.0 milestone Oct 2, 2026
@pllim
pllim requested a review from neutrinoceros as a code owner October 2, 2026 20:17
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

pllim
pllim commented Oct 2, 2026
View reviewed changes
Comment thread .github/workflows/stalebot.yml
repo-token: ${{ secrets.GITHUB_TOKEN }}
operations-per-run: 200
ascending: true # Old stuff first
remove-stale-when-updated: false

@pllim pllim Oct 2, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the only part I am not sure about. According to https://github.com/actions/stale documentation, update means comments too, but we don't want that. We only want the timer to reset on new commit. Is there a way to ask actions/stale to only count last commit timestamp of a PR?

Our current policy: https://docs.astropy.org/en/latest/development/maintainers/maintainer_workflow.html#stale-policies

@pllim
pllim requested review from Cadair, astrofrog and bsipocz October 2, 2026 20:52

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neutrinoceros neutrinoceros Awaiting requested review from neutrinoceros neutrinoceros is a code owner
@astrofrog astrofrog Awaiting requested review from astrofrog
@Cadair Cadair Awaiting requested review from Cadair
@bsipocz bsipocz Awaiting requested review from bsipocz

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

dev-automation no-changelog-entry-needed

Projects

None yet

Milestone

v8.1.0

Development

Successfully merging this pull request may close these issues.

Swap out custom stale bot with actions/stale

1 participant

@pllim