Skip to content

TYP: fix remaining type-check type errors in astropy/config - #20479

Open
neutrinoceros wants to merge 4 commits into
astropy:mainfrom
neutrinoceros:typ/config
Open

neutrinoceros wants to merge 4 commits into
astropy:mainfrom
neutrinoceros:typ/config

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Description

Resolves all 20 remaining violations found with ty check astropy/config.

AI Disclosure

N/A

  • I certify that I am human and that I take full responsibility for this pull request including all interactions with reviewers.

Merge method

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v8.1.0 milestone Sep 25, 2026
@neutrinoceros neutrinoceros added typing related to type annotations no-changelog-entry-needed labels Sep 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros neutrinoceros changed the title TYP: fix most remaining type-check type errors in astropy/config TYP: fix remaining type-check type errors in astropy/config Sep 30, 2026
@neutrinoceros
neutrinoceros marked this pull request as draft September 30, 2026 17:03
@neutrinoceros
neutrinoceros marked this pull request as ready for review September 30, 2026 17:07

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant