Skip to content

Backport PR #13614 on branch v5.1.x (MNT: Compatibility with Python 3.11) - #13665

Merged
pllim merged 1 commit into
astropy:v5.1.xfrom
pllim:manual-backport-of-pr-13614-on-v5.1.x
Sep 15, 2022
Merged

Backport PR #13614 on branch v5.1.x (MNT: Compatibility with Python 3.11)#13665
pllim merged 1 commit into
astropy:v5.1.xfrom
pllim:manual-backport-of-pr-13614-on-v5.1.x

Conversation

@pllim

@pllim pllim commented Sep 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This pull request is to manually backport #13614 into v5.1.x branch.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Do the proposed changes need the code-style fixed?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@pllim
Backport PR astropy#13614: MNT: Compatibility with Python 3.11
26d4da6 
Merge pull request astropy#13614 from Cadair/311_testing

MNT: Compatibility with Python 3.11
(cherry picked from commit 616f382)
@pllim pllim added skip-changelog-checks Tells bot to skip changlog checks skip-basebranch-check Skip base branch check for direct backports labels Sep 14, 2022
@pllim pllim added this to the v5.1.1 milestone Sep 14, 2022
@pllim
pllim requested a review from Cadair September 14, 2022 16:34
@olebole

olebole commented Sep 15, 2022

Copy link
Copy Markdown
Member

@pllim is it planned to have a 5.1.1 release after this PR is merged?

@pllim

pllim commented Sep 15, 2022

Copy link
Copy Markdown
Member Author

Re: release -- I am not sure. That is for @astropy/astropy-project-release-team to decide. Hopefully the answer is yes since Python 3.11 is coming out soon.

@pllim
pllim merged commit 6565ad9 into astropy:v5.1.x Sep 15, 2022
@pllim
pllim deleted the manual-backport-of-pr-13614-on-v5.1.x branch September 15, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cadair Cadair Awaiting requested review from Cadair

Assignees

No one assigned

Labels

cosmology io.ascii Ready-for-final-review skip-basebranch-check Skip base branch check for direct backports skip-changelog-checks Tells bot to skip changlog checks testing time utils

Projects

None yet

Milestone

v5.1.1

Development

Successfully merging this pull request may close these issues.

2 participants

@pllim @olebole