Repository navigation
Fix Python 3.11 issue for pprint_include/exclude_names - #13639
Merged
Merged
Conversation
Member
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
10 tasks done
Member
|
I have merged this into #13614 to let it run in the CI as well fwiw. |
pllim
approved these changes
Sep 12, 2022
pllim
left a comment
pllim
left a comment
Member
There was a problem hiding this comment.
Seems to fix the Python 3.11 errors over at Stuart's PR, so I am approving. Thanks!
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Sep 12, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Sep 12, 2022
Contributor
|
Belated approval... Makes sense to just try to fix the problem keeping the behaviour identical for now. |
pllim
added a commit
that referenced
this pull request
Sep 12, 2022
…639-on-v5.0.x Backport PR #13639 on branch v5.0.x (Fix Python 3.11 issue for pprint_include/exclude_names)
pllim
added a commit
that referenced
this pull request
Sep 12, 2022
…639-on-v5.1.x Backport PR #13639 on branch v5.1.x (Fix Python 3.11 issue for pprint_include/exclude_names)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to the Python 3.11 failure in
test_pprintwhich is due to a change in behavior forOrderedDict.pop()(presumably python/cpython#27530).This PR restores the Python <= 3.10 behavior where removing a column ends up calling
TableColumns.__delitem__.I ran the astropy unit tests with Python 3.11-rc1 and the table tests passed. BTW, the Table tests took 21.8 sec with Python 3.8 and 8.3 sec with Python 3.11. Wow! I want.
Fixes #13637
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.