Skip to content

minversion should return true for a final release if required version is 1.00dev #5814

Closed

Description

@kain88-de

I'm trying to update the conda-forge package with numpy 1.12, conda-forge/astropy-feedstock#7

This fails because of the function call minversion('numpy', '1.12dev'). There is a type Error in the final comparison. I assume parse_version doesn't strip the dev. I would be nice if minversion would allow that minversion('package', '1.00dev') returns true if the release version of the package is installed.

Activity

  1. astrofrog commented on Feb 15, 2017

    @astrofrog
    Member

    In the short term, that comparison should be changed to not have the dev anyway since Numpy 1.12 is out, and in the long term we should also prevent this kind of issue.

  2. kain88-de commented on Feb 15, 2017

    @kain88-de
    Author

    The numpy version is already fixed in master. This would help only in future releases that work check for numpy 1.13dev before it's released.

  3. added a commit that references this issue on Apr 20, 2017
  4. added a commit that references this issue on May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions