You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
minversion should return true for a final release if required version is 1.00dev #5814
This fails because of the function call minversion('numpy', '1.12dev'). There is a type Error in the final comparison. I assume parse_version doesn't strip the dev. I would be nice if minversion would allow that minversion('package', '1.00dev') returns true if the release version of the package is installed.
In the short term, that comparison should be changed to not have the dev anyway since Numpy 1.12 is out, and in the long term we should also prevent this kind of issue.
Activity
astrofrog commentedon Feb 15, 2017
In the short term, that comparison should be changed to not have the dev anyway since Numpy 1.12 is out, and in the long term we should also prevent this kind of issue.
kain88-de commentedon Feb 15, 2017
The numpy version is already fixed in master. This would help only in future releases that work check for numpy 1.13dev before it's released.
Merge pull request #5944 from joergdietrich/#5814
Merge pull request #5944 from joergdietrich/#5814