Conversation
loaff123
marked this pull request as ready for review
October 2, 2026 09:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #240.
A DataFrame containing integer and floating columns can expose a shared floating-point
.valuesmatrix. Integers are converted before formatting:intfmtis ignored and values above the exact floating-point range can round, for example2**53 + 1.When that matrix has a floating dtype and an integer column is present, read plain row tuples with
itertuples(index=False, name=None). Preserve existing index/header handling and column order, including duplicate names, and retain the matrix path for other inputs. Tests cover large signed/unsigned values, indices, column labels, empty dimensions, nullable values, mixed text, and temporal controls. The README documents the bounded numeric-column behavior.Validation rerun on Windows 11 / Python 3.11.9 / NumPy 2.4.6 / pandas 3.0.6:
python -m pytest -q: 413 passed, 1 skipped, including doctests.checkandformat --check: passed.git diff --check: passed.Ruff 0.16.10 was also attempted and reported newer lint/README formatting diagnostics; the passing lint run uses the project's declared development minimum, 0.15.4. No source was changed to resolve unrelated tool-version diagnostics.
AI assistance was used to prepare and verify the patch. Archived Linux version-matrix/build/benchmark checks were not rerun here. Numeric categorical/complex inputs and global scalar inference are outside the fix. It is a correctness change with possible fixed overhead on small DataFrames; no new performance claim is made. Submitted for maintainer review and upstream CI.