Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Add AureliaSpa template #398

Closed
kmkatsma wants to merge 12 commits into from
Closed

Add AureliaSpa template #398

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
600aa17
updates for aurelia
Oct 18, 2016
f24fce8
clean up
Oct 18, 2016
28c778e
Add typings for node
Oct 22, 2016
1563578
removed local gitignroe
Oct 22, 2016
12120ef
Added in missing _placeholder.txt
Oct 22, 2016
b363ed7
Changes to C# Namespace for uniformity to other templates
Oct 22, 2016
fe5059c
Cleanup - 2.0 typings format, script tags to layout.cshtml
Oct 23, 2016
790b719
First round of code review cleanup
Oct 25, 2016
e8b2ba8
Booting aurelia into a div in Index.cshtml
Oct 26, 2016
5747fb8
HMR workaround applied (seems best "dev experience" for now)
Oct 26, 2016
48a8162
Removed commented line, reverted HMR hack
Oct 26, 2016
68bf670
fixed issues with publish
Oct 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
First round of code review cleanup
  • Loading branch information
@kmkatsma
kmkatsma committed Oct 25, 2016
commit 790b7196e5317bd490176bb64d262108f7c13599
4 changes: 2 additions & 2 deletions templates/AureliaSpa/Aurelia.xproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
<Import Project="$(VSToolsPath)\DotNet\Microsoft.DotNet.Props" Condition="'$(VSToolsPath)' != ''" />
<PropertyGroup Label="Globals">
<ProjectGuid>33d8dad9-74f9-471d-8bad-55f828faa736</ProjectGuid>
<RootNamespace>Angular2</RootNamespace>
<RootNamespace>Aurelia</RootNamespace>
<TargetFrameworkVersion>v4.5.2</TargetFrameworkVersion>
</PropertyGroup>
<PropertyGroup>
<SchemaVersion>2.0</SchemaVersion>
</PropertyGroup>
<Import Project="$(VSToolsPath)\DotNet.Web\Microsoft.DotNet.Web.targets" Condition="'$(VSToolsPath)' != ''" />
</Project>
</Project>
10 changes: 5 additions & 5 deletions templates/AureliaSpa/ClientApp/app/components/app/app.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<template>

ghost Oct 24, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent quote style in this file. In TypeScript let's use single-quotes. In HTML templates, I don't know if Aurelia community has a standard, but can you find out what it is and use that?

ghost Oct 24, 2016 •
edited by EisenbergEffect
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer single quotes in JS/TS and double quotes in HTML.

<require from="../navmenu/navmenu.html"></require>
<require from="./app.css"></require>
<div class='container-fluid'>
<div class='row'>
<div class='col-sm-3'>
<div class="container-fluid">
<div class="row">
<div class="col-sm-3">
<navmenu router.bind="router"></navmenu>
</div>
<div class='col-sm-9 body-content'>
<div class="col-sm-9 body-content">
<router-view></router-view>
</div>
</div>
</div>
</template>
</template>
26 changes: 12 additions & 14 deletions templates/AureliaSpa/ClientApp/app/components/app/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,17 @@
import {Aurelia} from 'aurelia-framework';
import {Router, RouterConfiguration} from 'aurelia-router';
import { Aurelia } from 'aurelia-framework';
import { Router, RouterConfiguration } from 'aurelia-router';

export class App {
router: Router;
router: Router;

configureRouter(config: RouterConfiguration, router: Router) {
config.title = 'Aurelia';
config.map([
{ route: ['', 'home'], name: 'home', settings:{class:'home'}, moduleId: '../home/home', nav: true, title: 'Home' },
{ route: 'counter', name: 'counter', settings:{class:'education'}, moduleId: '../counter/counter', nav: true, title: 'Counter' },
{ route: 'fetch-data', name: 'fetchdata', settings:{class:'th-list'}, moduleId: '../fetchdata/fetchdata', nav: true, title: 'Fetch data' }
]);

this.router = router;
}
configureRouter(config: RouterConfiguration, router: Router) {
config.title = 'Aurelia';
config.map([
{ route: ['', 'home'], name: 'home', settings: {icon: 'home'}, moduleId: '../home/home', nav: true, title: 'Home' },
{ route: 'counter', name: 'counter', settings: {icon: 'education'}, moduleId: '../counter/counter', nav: true, title: 'Counter' },
{ route: 'fetch-data', name: 'fetchdata', settings: {icon: 'th-list'}, moduleId: '../fetchdata/fetchdata', nav: true, title: 'Fetch data' }
]);
this.router = router;
}
}


ghost Oct 24, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 18 seems like unnecessary whitespace, then there's a missing trailing linebreak.

2 changes: 1 addition & 1 deletion templates/AureliaSpa/ClientApp/app/components/counter/counter.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ <h2>Counter</h2>
<p>Current count: <strong>${currentCount}</strong></p>

<button click.delegate="incrementCounter()">Increment</button>
</template>
</template>
2 changes: 0 additions & 2 deletions templates/AureliaSpa/ClientApp/app/components/counter/counter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@

export class Counter {
public currentCount = 0;

public incrementCounter() {
this.currentCount++;

}
}
4 changes: 2 additions & 2 deletions templates/AureliaSpa/ClientApp/app/components/fetchdata/fetchdata.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ <h1>Weather forecast</h1>

<p if.bind="!forecasts"><em>Loading...</em></p>

<table class='table' if.bind="forecasts">
<table if.bind="forecasts" class="table">
<thead>
<tr>
<th>Date</th>
Expand All @@ -16,7 +16,7 @@ <h1>Weather forecast</h1>
</thead>
<tbody>
<tr repeat.for="forecast of forecasts">
<td>${forecast.dateFormatted }</td>
<td>${ forecast.dateFormatted }</td>
<td>${ forecast.temperatureC }</td>
<td>${ forecast.temperatureF }</td>
<td>${ forecast.summary }</td>
Expand Down
9 changes: 4 additions & 5 deletions templates/AureliaSpa/ClientApp/app/components/fetchdata/fetchdata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
/// <reference path="../../../../node_modules/aurelia-fetch-client/doc/whatwg-fetch.d.ts" />
/// <reference path="../../../../node_modules/aurelia-fetch-client/doc/url.d.ts" />

ghost Oct 24, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunate that these are necessary. Has the underlying issue in Aurelia been reported? Is there any chance of getting a fix published?

ghost Oct 24, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't have anything to do with Aurelia as far as I know. They are standards that TypeScript is missing for some reason. However, I don't think that reference comments should be needed either way.

ghost Oct 24, 2016 •
edited by SteveSandersonMS
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EisenbergEffect I think @kmkatsma was saying they are needed because aurelia-fetch-client currently contains an incorrect .d.ts file. Not sure though.

ghost Oct 24, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as we know, there's nothing incorrect in our dts. It's just that we use the Fetch spec which relies on the there being dts for fetch and url. Those should be provided by TS because they are standards, but they aren't, so you have to include your own. If there's something we need to fix on our side, we're happy to do it though.

ghost Oct 24, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, OK, that makes sense!

@kmkatsma In that case, the solution may be to reference whatwg-fetch from types in tsconfig.json, just like we do in the Knockout and ReactRedux templates. Then you should be able to remove these /// <reference> lines and have it still build.

ghost Oct 24, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in general the change in type references for TS 2.0 was something I only realized this Saturday as I was cleaning up some things. Will look at.

import {HttpClient} from 'aurelia-fetch-client';
import {inject} from 'aurelia-framework';
import { HttpClient } from 'aurelia-fetch-client';
import { inject } from 'aurelia-framework';

@inject(HttpClient)
export class Fetchdata {
public forecasts: WeatherForecast[];
http: HttpClient;

ghost Oct 24, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why store this as a member property? It doesn't seem to be used anywhere outside the constructor.

ghost Oct 24, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I do find this entire class to be odd. I usually discourage making AJAX requests in a constructor function. Is this the way that other templates do it as well? Usually, a better practice is to have a service abstraction or "repository" type class that encapsulates the use of the http client and provides a simple method such as getForecast() to get the data. Internally, the method can cache that data if it wants to but it would always return a promise for consistency.

ghost Oct 24, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EisenbergEffect It's the simplicity/extensibility tradeoff. In the Angular/Knockout/React templates we've followed this exact approach, as we're trying to make the templates accessible to newcompers and limit the concept count. People who get into using one of those frameworks won't struggle to create a service layer. In the ReactRedux template, we do the whole Redux thing which is a whole extra level of sophistication, but that's just fundamental to doing Redux. I think for this Aurelia template it's a reasonable choice of simplicity vs extensibility already, but we could change it if you think it's just flat out bad.



constructor(http: HttpClient) {
this.http = http;
this.http.fetch('/api/SampleData/WeatherForecasts')
//this.http = http;
http.fetch('/api/SampleData/WeatherForecasts')
.then(result => result.json())
.then(data => {
this.forecasts = data;
Expand Down
10 changes: 4 additions & 6 deletions templates/AureliaSpa/ClientApp/app/components/home/home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,15 @@
<h1>Hello, world!</h1>
<p>Welcome to your new single-page application, built with:</p>
<ul>
<li><a href='https://get.asp.net/'>ASP.NET Core</a> and <a href='https://msdn.microsoft.com/en-us/library/67ef8sbd.aspx'>C#</a> for cross-platform server-side code</li>
<li><a href='https://angular.io/'>Angular 2</a> and <a href='http://www.typescriptlang.org/'>TypeScript</a> for client-side code</li>
<li><a href='https://webpack.github.io/'>Webpack</a> for building and bundling client-side resources</li>
<li><a href='http://getbootstrap.com/'>Bootstrap</a> for layout and styling</li>
<li><a href="https://get.asp.net/">ASP.NET Core</a> and <a href="https://msdn.microsoft.com/en-us/library/67ef8sbd.aspx">C#</a> for cross-platform server-side code</li>
<li><a href="https://aurelia.io/">Aurelia</a> and <a href="http://www.typescriptlang.org/">TypeScript</a> for client-side code</li>
<li><a href="https://webpack.github.io/">Webpack</a> for building and bundling client-side resources</li>
<li><a href="http://getbootstrap.com/">Bootstrap</a> for layout and styling</li>
</ul>
<p>To help you get started, we've also set up:</p>
<ul>
<li><strong>Client-side navigation</strong>. For example, click <em>Counter</em> then <em>Back</em> to return here.</li>
<li><strong>Server-side prerendering</strong>. For faster initial loading and improved SEO, your Angular 2 app is prerendered on the server. The resulting HTML is then transferred to the browser where a client-side copy of the app takes over.</li>
<li><strong>Webpack dev middleware</strong>. In development mode, there's no need to run the <code>webpack</code> build tool. Your client-side resources are dynamically built on demand. Updates are available as soon as you modify any file.</li>
<li><strong>Hot module replacement</strong>. In development mode, you don't even need to reload the page after making most changes. Within seconds of saving changes to files, your Angular 2 app will be rebuilt and a new instance injected is into the page.</li>
<li><strong>Efficient production builds</strong>. In production mode, development-time features are disabled, and the <code>webpack</code> build tool produces minified static CSS and JavaScript files.</li>
</ul>
</template>
30 changes: 15 additions & 15 deletions templates/AureliaSpa/ClientApp/app/components/navmenu/navmenu.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
<template bindable="router">

ghost Oct 24, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent quotes in this file

<require from="./navmenu.css"></require>
<div class='main-nav'>
<div class='navbar navbar-inverse'>
<div class='navbar-header'>
<button type='button' class='navbar-toggle' data-toggle='collapse' data-target='.navbar-collapse'>
<span class='sr-only'>Toggle navigation</span>
<span class='icon-bar'></span>
<span class='icon-bar'></span>
<span class='icon-bar'></span>
<div class="main-nav">
<div class="navbar navbar-inverse">
<div class="navbar-header">
<button type="button" class="navbar-toggle" data-toggle="collapse" data-target=".navbar-collapse">
<span class="sr-only">Toggle navigation</span>
<span class="icon-bar"></span>
<span class="icon-bar"></span>
<span class="icon-bar"></span>
</button>
<a class='navbar-brand' href="#/home">Aurelia</a>
<a class="navbar-brand" href="#/home">Aurelia</a>
</div>
<div class='clearfix'></div>
<div class='navbar-collapse collapse'>
<ul class='nav navbar-nav'>
<li class="${row.isActive ? 'link-active' : ''}" repeat.for = "row of router.navigation" >
<div class="clearfix"></div>
<div class="navbar-collapse collapse">
<ul class="nav navbar-nav">
<li repeat.for = "row of router.navigation" class="${ row.isActive ? 'link-active' : '' }" >
<a href.bind = "row.href">
<span class='glyphicon glyphicon-${row.settings.class}'></span> ${row.title}
<span class="glyphicon glyphicon-${ row.settings.icon }"></span> ${ row.title }
</a>
</li>
</ul>
</div>
</div>
</div>
</template>
</template>
18 changes: 7 additions & 11 deletions templates/AureliaSpa/ClientApp/boot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
import {Aurelia} from 'aurelia-framework';
import { Aurelia } from 'aurelia-framework';
import 'bootstrap/dist/css/bootstrap.css';
import 'bootstrap';

// comment out if you don't want a Promise polyfill (remove also from webpack.config.js)
import * as Bluebird from 'bluebird';
Bluebird.config({ warnings: false });

export function configure(aurelia: Aurelia) {
aurelia.use
.standardConfiguration()
.developmentLogging();

aurelia.start().then(() => aurelia.setRoot('app/components/app/app'));
}
aurelia.use.standardConfiguration();
if (window.location.host.includes('localhost')) {
aurelia.use.developmentLogging();
}
aurelia.start().then(() => aurelia.setRoot('app/components/app/app'));
}
5 changes: 3 additions & 2 deletions templates/AureliaSpa/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
FROM microsoft/dotnet:latest
FROM microsoft/dotnet:1.0.0-preview2-onbuild

RUN apt-get update
RUN apt-get install -y build-essential nodejs nodejs-legacy
RUN wget -qO- https://deb.nodesource.com/setup_4.x | bash -
RUN apt-get install -y build-essential nodejs

WORKDIR /app

Expand Down
47 changes: 23 additions & 24 deletions templates/AureliaSpa/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,39 @@
# Welcome to ASP.NET 5
# Welcome to ASP.NET Core

We've made some big updates in this release, so it’s **important** that you spend a few minutes to learn what’s new.

You've created a new ASP.NET 5 project. [Learn what's new](http://go.microsoft.com/fwlink/?LinkId=518016)
You've created a new ASP.NET Core project. [Learn what's new](https://go.microsoft.com/fwlink/?LinkId=518016)

## This application consists of:

* Sample pages using ASP.NET MVC 6
* [Gulp](http://go.microsoft.com/fwlink/?LinkId=518007) and [Bower](http://go.microsoft.com/fwlink/?LinkId=518004) for managing client-side libraries
* Theming using [Bootstrap](http://go.microsoft.com/fwlink/?LinkID=398939)
* Sample pages using ASP.NET Core MVC
* [Gulp](https://go.microsoft.com/fwlink/?LinkId=518007) and [Bower](https://go.microsoft.com/fwlink/?LinkId=518004) for managing client-side libraries
* Theming using [Bootstrap](https://go.microsoft.com/fwlink/?LinkID=398939)

## How to

* [Add a Controller and View](http://go.microsoft.com/fwlink/?LinkID=398600)
* [Add an appsetting in config and access it in app.](http://go.microsoft.com/fwlink/?LinkID=699562)
* [Manage User Secrets using Secret Manager.](http://go.microsoft.com/fwlink/?LinkId=699315)
* [Use logging to log a message.](http://go.microsoft.com/fwlink/?LinkId=699316)
* [Add packages using NuGet.](http://go.microsoft.com/fwlink/?LinkId=699317)
* [Add client packages using Bower.](http://go.microsoft.com/fwlink/?LinkId=699318)
* [Target development, staging or production environment.](http://go.microsoft.com/fwlink/?LinkId=699319)
* [Add a Controller and View](https://go.microsoft.com/fwlink/?LinkID=398600)
* [Add an appsetting in config and access it in app.](https://go.microsoft.com/fwlink/?LinkID=699562)
* [Manage User Secrets using Secret Manager.](https://go.microsoft.com/fwlink/?LinkId=699315)
* [Use logging to log a message.](https://go.microsoft.com/fwlink/?LinkId=699316)
* [Add packages using NuGet.](https://go.microsoft.com/fwlink/?LinkId=699317)
* [Add client packages using Bower.](https://go.microsoft.com/fwlink/?LinkId=699318)
* [Target development, staging or production environment.](https://go.microsoft.com/fwlink/?LinkId=699319)

## Overview

* [Conceptual overview of what is ASP.NET 5](http://go.microsoft.com/fwlink/?LinkId=518008)
* [Fundamentals of ASP.NET 5 such as Startup and middleware.](http://go.microsoft.com/fwlink/?LinkId=699320)
* [Working with Data](http://go.microsoft.com/fwlink/?LinkId=398602)
* [Security](http://go.microsoft.com/fwlink/?LinkId=398603)
* [Client side development](http://go.microsoft.com/fwlink/?LinkID=699321)
* [Develop on different platforms](http://go.microsoft.com/fwlink/?LinkID=699322)
* [Read more on the documentation site](http://go.microsoft.com/fwlink/?LinkID=699323)
* [Conceptual overview of what is ASP.NET Core](https://go.microsoft.com/fwlink/?LinkId=518008)
* [Fundamentals of ASP.NET Core such as Startup and middleware.](https://go.microsoft.com/fwlink/?LinkId=699320)
* [Working with Data](https://go.microsoft.com/fwlink/?LinkId=398602)
* [Security](https://go.microsoft.com/fwlink/?LinkId=398603)
* [Client side development](https://go.microsoft.com/fwlink/?LinkID=699321)
* [Develop on different platforms](https://go.microsoft.com/fwlink/?LinkID=699322)
* [Read more on the documentation site](https://go.microsoft.com/fwlink/?LinkID=699323)

## Run & Deploy

* [Run your app](http://go.microsoft.com/fwlink/?LinkID=517851)
* [Run your app on .NET Core](http://go.microsoft.com/fwlink/?LinkID=517852)
* [Run commands in your project.json](http://go.microsoft.com/fwlink/?LinkID=517853)
* [Publish to Microsoft Azure Web Apps](http://go.microsoft.com/fwlink/?LinkID=398609)
* [Run your app](https://go.microsoft.com/fwlink/?LinkID=517851)
* [Run tools such as EF migrations and more](https://go.microsoft.com/fwlink/?LinkID=517853)
* [Publish to Microsoft Azure Web Apps](https://go.microsoft.com/fwlink/?LinkID=398609)

We would love to hear your [feedback](http://go.microsoft.com/fwlink/?LinkId=518015)
We would love to hear your [feedback](https://go.microsoft.com/fwlink/?LinkId=518015)
1 change: 1 addition & 0 deletions templates/AureliaSpa/Startup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerF
if (env.IsDevelopment())
{
app.UseDeveloperExceptionPage();
// Aurelia Webpack Plugin currently does not support HMR beyond CSS, leave HotModuleReplacement flag set to false
app.UseWebpackDevMiddleware(new WebpackDevMiddlewareOptions {
HotModuleReplacement = false

ghost Oct 24, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we'll get away with just setting this to false. The problem is, people will change it to true, and then you get a really weird and non-descriptive error that people will regard as a bug. It's reasonable for people to think that if some option exists that you should be able to use it.

Obviously the ideal solution would be if HMR could be made to work. I'd hope that's not impossible, since it's quite trivial to enable with Angular/Knockout/React, but I don't know if Aurelia does something that can't handle it.

If it's not possible to make work, can you somehow stop the unrelated-seeming error message, and replace it with something like "Sorry, Hot Module Replacement is not supported with Aurelia"?

});
Expand Down
3 changes: 1 addition & 2 deletions templates/AureliaSpa/Views/Home/Index.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
}

@section scripts {

ghost Oct 24, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why the client should be doing 3 separate HTTP requests for these JS files? Couldn't the bootstrap and modules bundles be a single bundle? (Ideally, all the vendor dependencies would be in a single file)

<script type="text/javascript" src="~/dist/aurelia-bootstrap-bundle.js" asp-append-version="true"></script>
<script type="text/javascript" src="~/dist/aurelia-modules-bundle.js"asp-append-version="true"></script>
<script type="text/javascript" src="~/dist/app-bundle.js" asp-append-version="true"></script>
}
}
14 changes: 2 additions & 12 deletions templates/AureliaSpa/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,7 @@
{
"name": "AureliaSpa",
"version": "0.0.0",
"aurelia": {
"build": {
"includeDependencies": "aurelia-*"
}
},
"dependencies": {
"@types/bluebird": "^3.0.35",
"@types/node": "^6.0.45",
"aurelia-bootstrapper-webpack": "^1.0.0",
"aurelia-event-aggregator": "^1.0.0",
"aurelia-fetch-client": "^1.0.0",
Expand All @@ -23,14 +16,12 @@
"aurelia-templating-binding": "^1.0.0",
"aurelia-templating-resources": "^1.0.0",
"aurelia-templating-router": "^1.0.0",
"bluebird": "^3.4.1",
"bootstrap": "^3.3.7",
"isomorphic-fetch": "^2.2.1",
"jquery": "^2.2.1",
"preboot": "^4.5.2"
"jquery": "^2.2.1"
},
"devDependencies": {

ghost Oct 24, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's valid to regard these as devDependencies. When you're publishing to production, isn't the publish script set up so that it would only restore dependencies, and then the webpack compilation would fail?

ghost Oct 25, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In production mode, I wouldn't think we'd have a dependency on webpack. I would just move everything to dependencies section (Angular2 template is set up this way), but the aurelia-webpack-plugin currently scans the package.json dependencies and also adds them to the bundle (I'm assuming in case there is missing import chain). So keeping dependencies section to a minimum is ideal.

"aspnet-prerendering": "^1.0.6",
"@types/node": "^6.0.45",

ghost Oct 28, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the node types used for?

"aspnet-webpack": "^1.0.11",
"aurelia-webpack-plugin": "^1.1.0",
"copy-webpack-plugin": "^3.0.1",
Expand All @@ -41,7 +32,6 @@
"html-loader": "^0.4.4",
"html-webpack-plugin": "^2.22.0",
"raw-loader": "^0.5.1",
"sourcemap-istanbul-instrumenter-loader": "^0.2.0",
"style-loader": "^0.13.1",
"to-string-loader": "^1.1.5",
"ts-loader": "^0.8.2",
Expand Down
6 changes: 2 additions & 4 deletions templates/AureliaSpa/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,8 @@
"appsettings.json",
"ClientApp/dist",
"node_modules",
"tsconfig.json",
"tsd.json",
"Views",
"web.config",
"webpack.*.js",
"wwwroot"
]
},
Expand All @@ -71,6 +69,6 @@
},

"tooling": {
"defaultNamespace": "Aurelia"
"defaultNamespace": "WebApplicationBasic"
}
}
2 changes: 1 addition & 1 deletion templates/AureliaSpa/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"emitDecoratorMetadata": true,
"skipDefaultLibCheck": true,
"lib": [ "es6", "dom" ],
"types": [ "node","bluebird" ]
"types": [ "node" ]
},
"exclude": [ "bin", "node_modules" ],
"atom": { "rewriteTsconfig": false }
Expand Down
14 changes: 0 additions & 14 deletions templates/AureliaSpa/web.config
View file
Open in desktop

This file was deleted.

Loading