Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Serialize node invocationInfo JSON directly to stream to avoid running out of memory #314

Merged
SteveSandersonMS merged 2 commits into from
Oct 5, 2016
Merged

Serialize node invocationInfo JSON directly to stream to avoid running out of memory #314

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cdf4f7
Serialize node invocationInfo JSON directly to stream to avoid runnin…
Sep 16, 2016
b6835e8
Remove cancellationToken parameter as the method is no longer async
Sep 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove cancellationToken parameter as the method is no longer async
  • Loading branch information
Brad Christensen
Brad Christensen committed Sep 16, 2016
commit b6835e8b30ce5e9efae0b14d8f27d407763ea392
4 changes: 2 additions & 2 deletions src/Microsoft.AspNetCore.NodeServices/HostingModels/SocketNodeInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ protected override async Task<T> InvokeExportAsync<T>(NodeInvocationInfo invocat
virtualConnection = _virtualConnectionClient.OpenVirtualConnection();

// Send request
WriteJsonLine(virtualConnection, invocationInfo, cancellationToken);
WriteJsonLine(virtualConnection, invocationInfo);

// Determine what kind of response format is expected
if (typeof(T) == typeof(Stream))
Expand Down Expand Up @@ -172,7 +172,7 @@ protected override void Dispose(bool disposing)
base.Dispose(disposing);
}

private static void WriteJsonLine(Stream stream, object serializableObject, CancellationToken cancellationToken)
private static void WriteJsonLine(Stream stream, object serializableObject)
{
using (var streamWriter = new StreamWriter(stream, utf8EncodingWithoutBom, streamBufferSize, true))
using (var jsonWriter = new JsonTextWriter(streamWriter))
Expand Down