HMR injects duplicate angular markup into the page #665

Activity

1. SteveSandersonMS

   added a commit that references this issue on Feb 13, 2017

   Remove the Angular 2.0.2 template; define the 2.4.5+ template as the …

   ...

   0ec6178
2. SteveSandersonMS commented on Feb 13, 2017

   

   SteveSandersonMS

   on Feb 13, 2017

   Member

   More actions

   Sorry about that. It was a mismatch between the logic needed for Angular 2.0.2 and 2.4.5+.

   To fix it, edit your boot-client.ts file, and just delete the following lines:

       // Before restarting the app, we create a new root element and dispose the old one
       const oldRootElem = document.querySelector(rootElemTagName);
       const newRootElem = document.createElement(rootElemTagName);
       oldRootElem.parentNode.insertBefore(newRootElem, oldRootElem);
   

   Leave the following one (that calls platform.destroy();) in place, as that's all that's needed on Angular 2.0.2.

   This will no longer be an issue, as we've removed the option to produce projects with older versions of Angular (the Angular template now only produces 2.4.5+ projects), hence closing this.

   👍React with 👍4Reacted by Steve Taylor, Mark Pieszak, Rejwanul Islam and Hayden Shelton
3. SteveSandersonMS

   closed this as completedon Feb 13, 2017
4. kkalitowski commented on Jul 28, 2017

   

   kkalitowski

   on Jul 28, 2017

   More actions

   Would you expect this to still be a problem with Microsoft.AspNetCore.SpaTemplates 0.9.3 that was using Angular 4? I'm still seeing the issue at that point (May'ish) and am wondering if the advice above is still the recommendation for that version.

   👍React with 👍1Reacted by Patrick Magee
5. SteveSandersonMS commented on Aug 1, 2017

   

   SteveSandersonMS

   on Aug 1, 2017

   Member

   More actions

   @kkalitowski Yes, nothing's changed about that yet as far as I know.

   👍React with 👍1Reacted by Rejwanul Islam
6. kkalitowski commented on Aug 1, 2017

   

   kkalitowski

   on Aug 1, 2017

   Last edited by kkalitowski

   More actions

   @SteveSanderson Gotcha. And that manual fix does work. I was referring to your Feb 13 note saying there should no longer be an issue. On a positive note, TrilonIO/aspnetcore-angular-universal@a83a6a9 was merged yesterday which fixes the issue.

   👍React with 👍1Reacted by Rejwanul Islam
7. irejwanul commented on Feb 3, 2018

   

   irejwanul

   on Feb 3, 2018

   More actions

   Angular 4.4.5, nothing improved yet. The solution of @SteveSanderson is working.