Updating to Typescript 2.5.2 produces error #1247

Activity

1. Trapulo commented on Sep 1, 2017

   

   Trapulo

   on Sep 1, 2017

   More actions

   same here

   nothing easy in this project :(
2. MarkPieszak commented on Sep 1, 2017

   

   MarkPieszak

   on Sep 1, 2017

   Contributor

   More actions

   It depends on which template you're using, but TypeScript isn't something that can be easily updated so quickly because all of the libraries and frameworks you're working with might not have upgraded to reflect the changes they made. "Minor" versions in TS seem to have breaking changes, even if only minor ones unfortunately. 😐
3. juergenr commented on Sep 2, 2017

   

   juergenr

   on Sep 2, 2017

   Author

   More actions

   I tested with different templates, including most current.
   I also updated all other package to the most current version.

   I think it's only one small change in line
   zone.onError.subscribe(errorInfo => reject(errorInfo));
   of boot-server.ts to get it running, with current typscript 2.5.2.

   Thanks for the great project!

   👍React with 👍3Reacted by Natalie Perret, wodzu and sebichondo
4. mmgrt commented on Sep 4, 2017

   

   mmgrt

   on Sep 4, 2017

   More actions

   Had this issue after updating my packages -angular template-, fixed it by defining zone along with it's type NgZone like this:
   const zone: NgZone = moduleRef.injector.get(NgZone);

   in the boot.server.ts file.

   👍React with 👍14Reacted by sebichondo, Asad Sahi, Pradeep Loganathan, Michel, Petre Turcu, Ken Goldthorpe, Demetrios Seferlis, Boban Stojanovski, Andrei Korober, Andrei Kitugin and 4 more
5. juergenr commented on Sep 5, 2017

   

   juergenr

   on Sep 5, 2017

   Author

   More actions

   Making zone typesafe solves the issue.
   Runing current typscript 2.5.2 works now!
   Thank you @mmgrt!
6. christos-kostopoulos commented on Sep 5, 2017

   

   christos-kostopoulos

   on Sep 5, 2017

   More actions

   const zone:any = moduleRef.injector.get(NgZone);

   👎React with 👎3Reacted by Asad Sahi, Andrei Kitugin and Kurtis Jungersen
7. SteveSandersonMS commented on Sep 6, 2017

   

   SteveSandersonMS

   on Sep 6, 2017

   Member

   More actions

   Thanks for letting us know.

   When we update the template sources to TypeScript 2.5.2+ this issue will inevitably surface and we'll use one of your suggested resolutions.

   Closing for now because there's no action to take on it (at least, not prior to updating to TypeScript 2.5.2).
8. SteveSandersonMS

   closed this as completedon Sep 6, 2017