Skip to content

Add f16 support for modulus and norm #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christophe-murphy merged 10 commits into from
Mar 7, 2025
Merged

Add f16 support for modulus and norm #3258

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
385a283
Add support for f16 for modulus operations
umar456 Jun 7, 2022
d05c2c6
Update float math functions to use f<op>f functions to maintain types
umar456 Jun 7, 2022
7d9ed1d
Add additional binary tests for integer types
umar456 Jun 7, 2022
68b5505
Add tests for norm
umar456 Jun 10, 2022
c388d51
Add support for half for norm
umar456 Jun 10, 2022
821df19
Added tests for norm and modulus. Made consistent modulus for ints in…
edwinsolisf Feb 4, 2025
186b306
Added more mod tests
edwinsolisf Feb 18, 2025
faf943d
Updated documentation to reflect status quo of the mod and rem expect…
edwinsolisf Feb 28, 2025
37e2982
Merge branch 'master' into half_mod
christophe-murphy Mar 7, 2025
dfe2ab9
Update copyright
christophe-murphy Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into half_mod
  • Loading branch information
@christophe-murphy
christophe-murphy authored Mar 7, 2025
commit 37e2982bc8f1afad2b0c0080f412b5086d225b89
38 changes: 22 additions & 16 deletions include/af/arith.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,11 @@ namespace af
/// For integers, it returns the same output as modulus (% operator)
/// For floating point numbers, it returns the same as std::remainder from <cmath>
///
/// \param[in] lhs is numerator
/// \param[in] rhs is denominator
/// \return remainder when \p rhs divides \p lhs
/// \param[in] lhs numerator; can be an array or a scalar
/// \param[in] rhs denominator; can be an array or a scalar
/// \return remainder
///
/// \ingroup arith_func_rem
AFAPI array rem (const array &lhs, const array &rhs);

/// \copydoc rem(const array&, const array&)
Expand All @@ -125,9 +127,11 @@ namespace af
/// For integers, it returns the same output as modulus (% operator)
/// For floating point numbers, it returns the same as std::fmod from <cmath>
///
/// \param[in] lhs is dividend
/// \param[in] rhs is divisor
/// \return \p lhs modulo \p rhs
/// \param[in] lhs dividend; can be an array or a scalar
/// \param[in] rhs divisor; can be an array or a scalar
/// \return modulus
///
/// \ingroup arith_func_mod
AFAPI array mod (const array &lhs, const array &rhs);

/// \copydoc mod(const array&, const array&)
Expand Down Expand Up @@ -989,11 +993,12 @@ extern "C" {
For integers, it returns the same output as modulus (% operator)
For floating point numbers, it returns the same as `remainder` from <math.h>

\param[out] out will contain the remainder of \p lhs divided by \p rhs
\param[in] lhs is numerator
\param[in] rhs is denominator
\param[in] batch specifies if operations need to be performed in batch mode
\return \ref AF_SUCCESS if the execution completes properly
\param[out] out remainder
\param[in] lhs numerator
\param[in] rhs denominator
\param[in] batch batch mode
\return \ref AF_SUCCESS, if function returns successfully, else
an \ref af_err code is given

\ingroup arith_func_rem
*/
Expand All @@ -1005,11 +1010,12 @@ extern "C" {
For integers, it returns the same output as modulus (% operator)
For floating point numbers, it returns the same as `fmod` from <math.h>

\param[out] out will contain the output of \p lhs modulo \p rhs
\param[in] lhs is dividend
\param[in] rhs is divisor
\param[in] batch specifies if operations need to be performed in batch mode
\return \ref AF_SUCCESS if the execution completes properly
\param[out] out modulus
\param[in] lhs dividend
\param[in] rhs divisor
\param[in] batch batch mode
\return \ref AF_SUCCESS, if function returns successfully, else
an \ref af_err code is given

\ingroup arith_func_mod
*/
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.