Skip to content

Improve the performance of CPU join and transpose #2849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
9prady9 merged 10 commits into from
Apr 22, 2020
Merged

Improve the performance of CPU join and transpose #2849

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
62f9a3a
Fix dereference of memory_info iterator before check
umar456 Apr 19, 2020
10d1177
Use double to calculate mean in random engine uniform tests if avialable
umar456 Apr 19, 2020
47e8d1f
Prevent the optimizations in the MeanOp on cpu.
umar456 Apr 19, 2020
678c5db
Fix the MatrixMultiplyBatch test so that we are testing the result
umar456 Apr 19, 2020
29aff9a
Remove unnecessary tile from var. Use arith output parameter instead
umar456 Apr 19, 2020
f595b68
Address all warnings with -Wall flags in GCC 9.3
umar456 Apr 20, 2020
01db684
Enable the -Wall flags if the compiler supports it
umar456 Apr 19, 2020
330a703
Speed up CPU transpose
umar456 Apr 19, 2020
5feead0
Optimize join using memcpy
umar456 Apr 19, 2020
e1cf3d1
Remove unnecessary instantiations of join in all backends
umar456 Apr 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix dereference of memory_info iterator before check
  • Loading branch information
@umar456
umar456 committed Apr 19, 2020
commit 62f9a3a88b56b4a59a27184e33a39b2ed4518759
12 changes: 5 additions & 7 deletions src/backend/common/DefaultMemoryManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,12 +166,11 @@ void *DefaultMemoryManager::alloc(bool user_lock, const unsigned ndims,

lock_guard_t lock(this->memory_mutex);
auto free_buffer_iter = current.free_map.find(alloc_bytes);
vector<void *> &free_buffer_vector = free_buffer_iter->second;

if (free_buffer_iter != current.free_map.end() &&
!free_buffer_vector.empty()) {
!free_buffer_iter->second.empty()) {
// Delete existing buffer info and underlying event
// Set to existing in from free map
vector<void *> &free_buffer_vector = free_buffer_iter->second;
ptr = free_buffer_vector.back();
free_buffer_vector.pop_back();
current.locked_map[ptr] = info;
Expand Down Expand Up @@ -223,15 +222,14 @@ void DefaultMemoryManager::unlock(void *ptr, bool user_unlock) {
memory_info &current = this->getCurrentMemoryInfo();

auto locked_buffer_iter = current.locked_map.find(ptr);
locked_info &locked_buffer_info = locked_buffer_iter->second;
void *locked_buffer_ptr = locked_buffer_iter->first;

// Pointer not found in locked map
if (locked_buffer_iter == current.locked_map.end()) {
// Pointer not found in locked map
// Probably came from user, just free it
freed_ptr.reset(ptr);
return;
}
locked_info &locked_buffer_info = locked_buffer_iter->second;
void *locked_buffer_ptr = locked_buffer_iter->first;

if (user_unlock) {
locked_buffer_info.user_lock = false;
Expand Down