Skip to content

Use runtime string conversion for AsBytes trait calls - #1694

Open
sbillig wants to merge 2 commits into
masterfrom
fix/runtime-string-as-bytes
Open

sbillig wants to merge 2 commits into
masterfrom
fix/runtime-string-as-bytes

Conversation

@sbillig

@sbillig sbillig commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Runtime calls through AsBytes for String<N>, including std::io::write, currently reach the const-only __as_bytes extern and fail native code generation. Delegate to the existing inherent string conversion, preserving fixed-width padding and truncation for runtime and constant callers.

Adds native and EVM regressions for generic trait dispatch.

@sbillig sbillig changed the title fix/runtime string as bytes Use runtime string conversion for AsBytes trait calls Oct 2, 2026
@sbillig
sbillig marked this pull request as ready for review October 2, 2026 00:15
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T00:39:11.291074Z dcfea47 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant