Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resource
parametersare copied to every operation by reference, andParameterResourceMetadataCollectionFactorythen adds the operation-specific parameters to that sharedParametersinstance. The first processed operation pollutes all the others, sooperations:on a parameter attribute is ignored as soon as the resource declaresparameters. Same fix as #8378 for the runtime providers: clone before mutating.Before
#[ApiResource( operations: [ new Get(), new GetCollection(), ], parameters: ['q' => new QueryParameter()], )] class Book { #[QueryParameter(operations: [new GetCollection()])] public string $title = ''; }titleis also declared onGet(and documented on the item operation), and on the resource itself.After
titleis only declared onGetCollection;qis still declared on both operations.