Skip to content

[ZEPPELIN-6663] Mark CompletionItem.meta optional to match completion payloads #5519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbonelee merged 1 commit into from
Oct 2, 2026
Merged

[ZEPPELIN-6663] Mark CompletionItem.meta optional to match completion payloads #5519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[ZEPPELIN-6663] Mark CompletionItem.meta optional to match completion… 
… payloads
  • Loading branch information
@JangAyeon
JangAyeon committed Oct 2, 2026
commit f46b56a35feb6ccf557f9e5910e94795d9e822e9
2 changes: 1 addition & 1 deletion zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-paragraph.interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ export interface Completion {
}

export interface CompletionItem {
meta: string;
meta?: string;
value: string;
name: string;
}
Expand Down
2 changes: 1 addition & 1 deletion zeppelin-web-angular/projects/zeppelin-sdk/tsconfig.spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"noEmit": true,
"types": ["node"]
},
"include": ["src/**/*.spec.ts"]
"include": ["src/**/*.spec.ts", "type-tests/**/*.ts"]
}
24 changes: 24 additions & 0 deletions zeppelin-web-angular/projects/zeppelin-sdk/type-tests/completion-item-meta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
/*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* http://www.apache.org/licenses/LICENSE-2.0
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import { CompletionItem } from '../src/interfaces/message-paragraph.interface';

// Spark and Flink interpreters build InterpreterCompletion(name, value, null), and
// NotebookServer's Gson omits null fields, so their completion payloads have no `meta` key.
export const sparkFlinkCompletion: CompletionItem = { name: 'println', value: 'println' };

// `name` and `value` are always supplied by production construction sites and must stay required.
// @ts-expect-error `name` is required
export const missingName: CompletionItem = { value: 'println' };

// @ts-expect-error `value` is required
export const missingValue: CompletionItem = { name: 'println' };
Loading