Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
For valid symbolic shapes, the
shape_to_tensorfallback inFoldConstantcan encounter aPrimExprthat is not anIntImmNode. Dereferencing it as an integer constant is unsafe. In the validshape_of -> shape_to_tensor -> tensor_to_shape -> reshapepath, reshape legalization also assumes a shapeVaris bound directly to aShapeExpr, but it may be bound to a call.Related to #20260.
Changes
shape_to_tensorthrough the C++ fallback only if each dimension is an int64IntImmNodewith a value representable asint64_t; otherwise retain the call.reshapewhen its target shapeVaris not bound to aShapeExpr, rather than asserting during legalization.FLegalizeto exercise the C++ path.Validation
tests/python/relax/test_transform_fold_constant.pyfile passes: 23 tests on the rebased source.FoldConstantwithout an exception.defaultandcpu_genericLLVM/CPU pipelines build and execute with input lengths 3 and 7; outputs match the inputs.Scope
Passing the Tensor result of
shape_to_tensordirectly toreshapewithouttensor_to_shaperemains outside this change. In the BlockBuilder reproducer, that input is rejected beforeFoldConstantbecausereshapeexpects a Shape-typed operand. This PR does not relax that contract.