THRIFT-6135: Set isset bits in Java constructors without calling setXIsSet() - #3970
Open
slachiewicz wants to merge 1 commit into
Open
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
…IsSet() Client: java A generated constructor marked a primitive field as set by calling the public, overridable setXIsSet(true), which javac 21 and later report as this-escape, an error under -Werror. The constructor now sets the bit directly, as that method does, so there is nothing to suppress. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A generated constructor marked a primitive field as set by calling the public, overridable
setXIsSet(true), which javac 21 and later report asthis-escape. The constructor now sets the bit directly, as that method does, so there is nothing to suppress. CI builds lib/java with JDK 17, which has no this-escape lint, so the check below was run locally.Verified: the Java generated for ThriftTest, DebugProtoTest, OptionalRequiredTest, ManyOptionals, JavaTypes and the IDL from the ticket compiles with
javac 21 -Xlint:this-escape -Werror(56 warnings before);gradle testin lib/java → 377 passed.