Conversation
The cross-language tests read Java-generated sketches from a top-level directory named "java", which suggests Java source code. Read them from serialization_test_data/java_generated_files instead, the layout used by datasketches-java and datasketches-go. - Update the 14 *_deserialize_from_java tests. - serde_compat workflow: check out Java into datasketches-java and copy its generated files into the new directory. - .gitignore: ignore serialization_test_data/, datasketches-java/ and all *.sk files, so snapshots can never be committed or released. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Coverage Report for CI Build 36944539689Coverage increased (+0.009%) to 82.436%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cross-language tests read Java-generated
.skfiles from a top-level directory namedjava/, which suggests Java source code. This moves them toserialization_test_data/java_generated_files/, the same layout datasketches-java and datasketches-go use (serialization_test_data/<language>_generated_files), which leaves room forcpp_andgo_generated_fileslater.Changes:
*_deserialize_from_javatests now read fromserialization_test_data/java_generated_files/.serde_compatworkflow: checks out datasketches-java intodatasketches-java/instead ofjava/, and copies its generated files into the new directory..gitignore: replacesjavawithserialization_test_data/,datasketches-java/and*.sk, so sketch snapshots can never be committed or end up in a release.Verified locally with the current Java snapshots from datasketches-tck (Java pin 059b5a9) in the new directory and
-DSERDE_COMPAT=true: all 17 test suites pass, including every[serde_compat]case. With the directory absent, the[serde_compat]cases fail, confirming the tests read the new location.🤖 Generated with Claude Code