Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Oct 2, 2026
dvasdekis
marked this pull request as ready for review
October 2, 2026 05:33
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2606 +/- ##
=======================================
Coverage 81.11% 81.11%
=======================================
Files 42 42
Lines 33707 33710 +3
Branches 33707 33710 +3
=======================================
+ Hits 27342 27345 +3
Misses 2796 2796
Partials 3569 3569 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSSQL: Support deferred ON clauses in right-nested joins
SELECT a.id FROM a LEFT JOIN b INNER JOIN c ON b.id = c.id ON a.id = b.idcurrently fails with MsSqlDialect.Enable the existing right-nested JOIN capability for MSSQL; preserve predicate ownership and outer-join grouping.
Test mixed join types, deeper chains, canonical round-trips, immediate-condition chains, and malformed predicates.
This only enables MSSQL: it does not duplicate the shared parser changes in #2445 or the recursion work in #2440.
Draft pending coordination with #2440 and #2445; follows the PostgreSQL enablement in #2377.
Syntax reference: https://learn.microsoft.com/en-us/sql/t-sql/queries/from-transact-sql
Validation:
cargo test --all-features, formatting, strict all-target/all-feature Clippy, and a bounded parser fuzz run.Scope: parsing and AST representation only; schema resolution and lineage validation belong to downstream analyzers.
All examples and fixtures are synthetic.
Prepared with GitHub Copilot assistance.