Skip to content

Using Profiler class, from the utils package, instead of System.currentTimeMillis() #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilderrodrigues wants to merge 2 commits into from
Closed

Using Profiler class, from the utils package, instead of System.currentTimeMillis() #525

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
617f61f
Formatting class ClusterServiceServletImpl
wilderrodrigues Jun 25, 2015
790ad55
Using Profiler class, from the utils package, instead of System.curre…
wilderrodrigues Jun 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Formatting class ClusterServiceServletImpl 
   - Splitting format commit from fix commit.
  • Loading branch information
@wilderrodrigues
wilderrodrigues committed Jun 25, 2015
commit 617f61f627c6d95cafea6e148d93ced88fb14a02
38 changes: 19 additions & 19 deletions framework/cluster/src/com/cloud/cluster/ClusterServiceServletImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,18 @@ public class ClusterServiceServletImpl implements ClusterService {
public ClusterServiceServletImpl() {
}

public ClusterServiceServletImpl(String serviceUrl) {
public ClusterServiceServletImpl(final String serviceUrl) {
s_logger.info("Setup cluster service servlet. service url: " + serviceUrl + ", request timeout: " + ClusterServiceAdapter.ClusterMessageTimeOut.value() +
" seconds");
" seconds");

_serviceUrl = serviceUrl;
}

@Override
public String execute(ClusterServicePdu pdu) throws RemoteException {
public String execute(final ClusterServicePdu pdu) throws RemoteException {

HttpClient client = getHttpClient();
PostMethod method = new PostMethod(_serviceUrl);
final HttpClient client = getHttpClient();
final PostMethod method = new PostMethod(_serviceUrl);

method.addParameter("method", Integer.toString(RemoteMethodConstants.METHOD_DELIVER_PDU));
method.addParameter("sourcePeer", pdu.getSourcePeer());
Expand All @@ -65,29 +65,29 @@ public String execute(ClusterServicePdu pdu) throws RemoteException {
}

@Override
public boolean ping(String callingPeer) throws RemoteException {
public boolean ping(final String callingPeer) throws RemoteException {
if (s_logger.isDebugEnabled()) {
s_logger.debug("Ping at " + _serviceUrl);
}

HttpClient client = getHttpClient();
PostMethod method = new PostMethod(_serviceUrl);
final HttpClient client = getHttpClient();
final PostMethod method = new PostMethod(_serviceUrl);

method.addParameter("method", Integer.toString(RemoteMethodConstants.METHOD_PING));
method.addParameter("callingPeer", callingPeer);

String returnVal = executePostMethod(client, method);
final String returnVal = executePostMethod(client, method);
if ("true".equalsIgnoreCase(returnVal)) {
return true;
}
return false;
}

private String executePostMethod(HttpClient client, PostMethod method) {
private String executePostMethod(final HttpClient client, final PostMethod method) {
int response = 0;
String result = null;
try {
long startTick = System.currentTimeMillis();
final long startTick = System.currentTimeMillis();
response = client.executeMethod(method);
if (response == HttpStatus.SC_OK) {
result = method.getResponseBodyAsString();
Expand All @@ -96,13 +96,13 @@ private String executePostMethod(HttpClient client, PostMethod method) {
}
} else {
s_logger.error("Invalid response code : " + response + ", from : " + _serviceUrl + ", method : " + method.getParameter("method") + " responding time: " +
(System.currentTimeMillis() - startTick));
(System.currentTimeMillis() - startTick));
}
} catch (HttpException e) {
} catch (final HttpException e) {
s_logger.error("HttpException from : " + _serviceUrl + ", method : " + method.getParameter("method"));
} catch (IOException e) {
} catch (final IOException e) {
s_logger.error("IOException from : " + _serviceUrl + ", method : " + method.getParameter("method"));
} catch (Throwable e) {
} catch (final Throwable e) {
s_logger.error("Exception from : " + _serviceUrl + ", method : " + method.getParameter("method") + ", exception :", e);
} finally {
method.releaseConnection();
Expand All @@ -114,14 +114,14 @@ private String executePostMethod(HttpClient client, PostMethod method) {
private HttpClient getHttpClient() {

if (s_client == null) {
MultiThreadedHttpConnectionManager mgr = new MultiThreadedHttpConnectionManager();
final MultiThreadedHttpConnectionManager mgr = new MultiThreadedHttpConnectionManager();
mgr.getParams().setDefaultMaxConnectionsPerHost(4);

// TODO make it configurable
mgr.getParams().setMaxTotalConnections(1000);

s_client = new HttpClient(mgr);
HttpClientParams clientParams = new HttpClientParams();
final HttpClientParams clientParams = new HttpClientParams();
clientParams.setSoTimeout(ClusterServiceAdapter.ClusterMessageTimeOut.value() * 1000);

s_client.setParams(clientParams);
Expand All @@ -130,14 +130,14 @@ private HttpClient getHttpClient() {
}

// for test purpose only
public static void main(String[] args) {
public static void main(final String[] args) {
/*
ClusterServiceServletImpl service = new ClusterServiceServletImpl("http://localhost:9090/clusterservice", 300);
try {
String result = service.execute("test", 1, "{ p1:v1, p2:v2 }", true);
System.out.println(result);
} catch (RemoteException e) {
}
*/
*/
}
}