Skip to content

CLOUDSTACK-7242: Adding a securing config using configDepo doesnt work #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karuturi wants to merge 4 commits into from
Closed

CLOUDSTACK-7242: Adding a securing config using configDepo doesnt work #34

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d5451c
Fixed CLOUDSTACK-7242: Adding a securing config using configDepo does…
karuturi Nov 4, 2014
0c2dc46
CLOUDSTACK-7384: UI > Instances > detailView > change service offerin…
Nov 4, 2014
f9060bc
CLOUDSTACK-7383: UI > Instances > detailView > snapshot option > hide…
Nov 4, 2014
c526056
CLOUDSTACK-7841: Gracefully reload haproxy config
Nov 5, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixed CLOUDSTACK-7242: Adding a securing config using configDepo does… 
…nt work

In ConfigurationVo, changed the setter to do the encryption if required
like the getter. Called the setter in constructor as well.

Removed references of encryption check in different places.
  • Loading branch information
@karuturi
karuturi committed Nov 4, 2014
commit 2d5451c5ed6688f26edd5bd0a86cf5616ee4729d
3 changes: 0 additions & 3 deletions framework/config/src/org/apache/cloudstack/framework/config/dao/ConfigurationDaoImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,6 @@ public String getValueAndInitIfNotExist(String name, String category, String ini
update(name, category, initValue);
}
} else {
if (category.equals("Hidden") || category.equals("Secure")) {
initValue = DBEncryptionUtil.encrypt(initValue);
}
ConfigurationVO newConfig = new ConfigurationVO(category, "DEFAULT", "management-server", name, initValue, desc);
persist(newConfig);
}
Expand Down
18 changes: 15 additions & 3 deletions framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigurationVO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ public ConfigurationVO(String category, String instance, String component, Strin
this.instance = instance;
this.component = component;
this.name = name;
this.value = value;
this.description = description;
setValue(value);
}

public ConfigurationVO(String component, ConfigKey<?> key) {
Expand Down Expand Up @@ -122,11 +122,23 @@ public void setName(String name) {

@Override
public String getValue() {
return (("Hidden".equals(getCategory()) || "Secure".equals(getCategory())) ? DBEncryptionUtil.decrypt(value) : value);
if(isEncryptedConfig()) {
return DBEncryptionUtil.decrypt(value);
} else {
return value;
}
}

public void setValue(String value) {
this.value = value;
if(isEncryptedConfig()) {
this.value = DBEncryptionUtil.encrypt(value);
} else {
this.value = value;
}
}

private boolean isEncryptedConfig() {
return "Hidden".equals(getCategory()) || "Secure".equals(getCategory());
}

@Override
Expand Down
3 changes: 1 addition & 2 deletions server/src/com/cloud/server/ConfigurationServerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@ public void persistDefaultValues() throws InternalErrorException {
String instance = "DEFAULT";
String component = c.getComponent();
String value = c.getDefaultValue();
value = ("Hidden".equals(category) || "Secure".equals(category)) ? DBEncryptionUtil.encrypt(value) : value;
String description = c.getDescription();
ConfigurationVO configVO = new ConfigurationVO(category, instance, component, name, value, description);
configVO.setDefaultValue(value);
Expand Down Expand Up @@ -635,7 +634,7 @@ protected void updateSSLKeystore() {
}
String base64Keystore = getBase64Keystore(keystorePath);
ConfigurationVO configVO =
new ConfigurationVO("Hidden", "DEFAULT", "management-server", "ssl.keystore", DBEncryptionUtil.encrypt(base64Keystore),
new ConfigurationVO("Hidden", "DEFAULT", "management-server", "ssl.keystore", base64Keystore,
"SSL Keystore for the management servers");
_configDao.persist(configVO);
s_logger.info("Stored SSL keystore to database.");
Expand Down