Skip to content

CLOUDSTACK-8335: use libvirt from central repository #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
K0zka wants to merge 1 commit into from
Closed

CLOUDSTACK-8335: use libvirt from central repository #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
CLOUDSTACK-8335: use libvirt from central repository 
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
  • Loading branch information
@K0zka
K0zka committed Apr 13, 2015
commit e1cc7897f57e13c9a73b90dd61e2f3551a519a2f
9 changes: 1 addition & 8 deletions plugins/hypervisors/kvm/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
<repositories>
<repository>
<id>libvirt-org</id>
<url>http://libvirt.org/maven2</url>
<snapshots>
<enabled>false</enabled>
</snapshots>
</repository>
<repository>
<id>ceph-com</id>
<url>http://ceph.com/maven</url>
Expand All @@ -45,7 +38,7 @@
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.libvirt</groupId>
<groupId>com.github.K0zka</groupId>

@yadvr yadvr Apr 13, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this fine? com.github.K0zka?
@K0zka will you be maintaining this repo?

@K0zka K0zka Apr 13, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Rohit,

I updated the group ID to that because I can publish with that group ID only and not with org.libvirt, unfortunately the libvirt maintainers do not seem to be interested in pushing their artifacts to central repo.
I agree that the groupId does not look good, but I haven't found another way. I will try to keep an up to date version in central repo untl libvirt maintainers accept the changes I have done on the pom.xml and publish to maven central, but this may take quite some time.

@yadvr yadvr Apr 15, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@K0zka in that case if you'll be maintaining it then we should merge it. Since, I'm not sure I'll wait for any of the KVM people to comment on it. (Wido, Kishan, Marcus?)

@kishankavala kishankavala Apr 15, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@K0zka Can we use something like org.apache.cloudstack.libvirt instead ?

@K0zka K0zka Apr 15, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kishankavala yes that is possible. I have to see how that could work together with the apache infrastructure, but I will be working on it. I will close this PR for now.

<artifactId>libvirt</artifactId>
<version>${cs.libvirt-java.version}</version>
</dependency>
Expand Down